From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id DD858C756 for ; Mon, 22 Jun 2015 09:50:28 +0200 (CEST) Received: by wiga1 with SMTP id a1so68202036wig.0 for ; Mon, 22 Jun 2015 00:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VALppYuloGgyH5Gtm0gQEPbCuPYKMsQDMdYQ7OMlj9k=; b=bGbRgkH73LFQNIIKqKvDbj9dk1AO2WC30B0USwTxhdFRBrnnxLV3C+mbBisDIIMOQR 6/lmWZdNTsc0DZ+o2Xsw8l8y+24C4+u1/M2iJZMGD7NB4DAFgom661SVf/lqy8zbbVE4 pojHwdSDeh4slK7wxZKHNsgU/YLrIyjcRv0rqqOvLZOahnVeOBlWwb72QX3m5vKWcj6T AIYbw17HmfxUBS9IcDV8Z+5+EDT1+VyQjPcTMv1eXKMIZ4CEaJsUJh6lGHXcokyh0Wj1 gGTEzDscFLXMcSAQhQzchX6aGZbsY09mswGpxOKC+tsUQ5mGtDMs1F8EZi0qQA5ZCEkf 0Fkg== X-Gm-Message-State: ALoCoQkMJjYMQ54T8MBVzLhZOI7VnjJJN2n9EhRG9oYoFegJXBb6qXoc8IHu8oowFkmitY9o2prV X-Received: by 10.194.76.132 with SMTP id k4mr48086727wjw.77.1434959428779; Mon, 22 Jun 2015 00:50:28 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u6sm29230823wja.40.2015.06.22.00.50.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 00:50:27 -0700 (PDT) From: Thomas Monjalon To: Jijiang Liu Date: Mon, 22 Jun 2015 09:49:27 +0200 Message-ID: <2269442.FSZeuyxEr5@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1434589417-5395-2-git-send-email-jijiang.liu@intel.com> References: <1434589417-5395-1-git-send-email-jijiang.liu@intel.com> <1434589417-5395-2-git-send-email-jijiang.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize the VXLAN sample X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 07:50:29 -0000 2015-06-18 09:03, Jijiang Liu: > This sample uses the basic virtio devices management function from th= e vHost example, which includes virtio device creation, destroying and = maintenance. Please wrap commit message to about 72 characters. https://github.com/erlang/otp/wiki/Writing-good-commit-messages https://git-scm.com/book/ch5-2.html typo in Makefile: overriden -> overridden There are 2 functions where ret is incremented but never initialized: examples/tep_termination/main.c:473:6: error: =E2=80=98ret=E2=80=99 may= be used uninitialized in this function examples/tep_termination/main.c:536:8: error: =E2=80=98ret=E2=80=99 may= be used uninitialized in this function Making a patch buildable with recent GCC and clang is the minimum befor= e submitting it.