From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode
Date: Tue, 06 Oct 2020 00:47:36 +0200 [thread overview]
Message-ID: <2270119.t8HXx4VqzU@thomas> (raw)
In-Reply-To: <DBAPR08MB58140240915BD5CF91A8B92D982A0@DBAPR08MB5814.eurprd08.prod.outlook.com>
> > Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a
> > single preprocessor token, user-defined-string-literal, in C++11 onwards.
> > While modern compilers are smart enough to parse this properly, GCC 9.3.0
> > generates warnings like:
> >
> > rte_rcu_qsbr.h:555:26: warning: invalid suffix on literal; C++11
> > requires a space between literal and string macro [-Wliteral-suffix]
> >
> > Add spaces around format specifier macros to make public headers
> > compatible with C++ without causing warnings. Make similar changes in C
> > source for style consistency within the library.
> >
> > Fixes: 64994b56c ("rcu: add RCU library supporting QSBR mechanism")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Looks good, Thank you.
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Applied, thanks
prev parent reply other threads:[~2020-10-05 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 21:38 [dpdk-dev] [PATCH] rcu: " Dmitry Kozlyuk
2020-09-04 6:27 ` Honnappa Nagarahalli
2020-09-04 20:47 ` [dpdk-dev] [PATCH v2] lib/rcu: " Dmitry Kozlyuk
2020-09-05 1:47 ` Honnappa Nagarahalli
2020-10-05 22:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2270119.t8HXx4VqzU@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).