From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B58FA04B1; Tue, 6 Oct 2020 00:47:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE5232BC7; Tue, 6 Oct 2020 00:47:43 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 01F902952; Tue, 6 Oct 2020 00:47:41 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 86CDE5C00E9; Mon, 5 Oct 2020 18:47:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 05 Oct 2020 18:47:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= MkGQqPO2UQ5OsOhNF8M89ewq29Fi5VwWx4kzWM9oLNU=; b=ExlcPXUE3KHjDbh3 YMJav28fB5YZRLZ3sgLLTS/8jBlnUVHDEWh3QV8CSmMeZSEpzfuJ3T1xw1jhrPx7 YDhE4hvJJPViUqNguerVkfBQT1wldgRGN3l07WJS3S2jobHtCAXy8mzRrYKa0rJy 5DLh9uvSEFRO11YO+TQmR8TN5MxfcadjJEN+ggzM955ZXBP18iKdixOfTzNiKyRR J+jFVhfimY3Oqrkc1vemeE818HURHD0DuwOxQjiIUaD/4Ejf9RhWb4Wac1JKA8Y+ KjEofc/c/a3SfgOeTBG5F9hQGsThX0EXXIKOy84kJwMh+8PdtFlago4gSlKHgpjj u7ngvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MkGQqPO2UQ5OsOhNF8M89ewq29Fi5VwWx4kzWM9oL NU=; b=Jn8WmVaCYPVxtV8baa6t6/SeCXvlegoZY6V3ouzDC4pS3v+5c+Z9I5pg3 jFg6Ur4OckYjjF3RTDJ/5leGtvZ7OT8SuV2Mf+M1A1Ta8CEUDA/PBF9qDZ77HQVl /jrW1rgf3509AseSIwwyWvMWNMst2ch8YB1fwpzMbyoGFvTSokU/miTDVWb1zjmV 1nQJWYiKLXD60DIK7W17u/LZB25iU+mZHJDCBkUOW5vPx1qdVUsc/Zuiev2SrD9m GGF5zmo2kbotTYKVLPyjdudEm1d1TCLBCiSizMMFZDTYzbUtJ0LUX+HtDLgc2BNe s2vs8I779ejqhvuSnUjeVtixYFIpw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeefgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 919313064682; Mon, 5 Oct 2020 18:47:38 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: "dev@dpdk.org" , "stable@dpdk.org" , nd , Honnappa Nagarahalli Date: Tue, 06 Oct 2020 00:47:36 +0200 Message-ID: <2270119.t8HXx4VqzU@thomas> In-Reply-To: References: <20200831213811.21521-1-dmitry.kozliuk@gmail.com> <20200904204734.17042-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a > > single preprocessor token, user-defined-string-literal, in C++11 onwards. > > While modern compilers are smart enough to parse this properly, GCC 9.3.0 > > generates warnings like: > > > > rte_rcu_qsbr.h:555:26: warning: invalid suffix on literal; C++11 > > requires a space between literal and string macro [-Wliteral-suffix] > > > > Add spaces around format specifier macros to make public headers > > compatible with C++ without causing warnings. Make similar changes in C > > source for style consistency within the library. > > > > Fixes: 64994b56c ("rcu: add RCU library supporting QSBR mechanism") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dmitry Kozlyuk > Looks good, Thank you. > Reviewed-by: Honnappa Nagarahalli Applied, thanks