From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 63B9E1B7EE
 for <dev@dpdk.org>; Wed, 11 Apr 2018 23:34:30 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id AE70B20E52;
 Wed, 11 Apr 2018 17:34:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 11 Apr 2018 17:34:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=YzAAeEew/i/rr7Bn7x0Oe316n+
 9TDXK9C+FpqTMRFM0=; b=KFK10yRKitZQKNkahgcWNoYxmBsu5pdZcGX5/yZ4n5
 pANYgJMFmG8oYEDIXAN8anRT+v9x+bnlaHhQq+d6YmjpewUqsoXrP6x+JIiMrruA
 Q355f+vQM6lu66hKXfJlVPJdNtBGQJ9LScawbjR7H49s/c0MV62hZlwtbG3rSCos
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=YzAAeE
 ew/i/rr7Bn7x0Oe316n+9TDXK9C+FpqTMRFM0=; b=Mfv5WD1zH0GnQv7UMb3RyW
 dkrNp/ozZQm5Bcgrr+ZxZc58xj48EaBBBPrxxIyzf7Pf4HSzi0+CkC64EOz+FRPV
 cCkRgLJGFKp6M9Z1RdwTEQfVZARRzjnYof4ZjWTfBrWKwv0PZ5VFAXERT8sc+46s
 IwQwNQK8L4PPV6z7bbxLr5WSH9GF8YyfGQarf/fU+BTGJW0csBXgVJCUonzSc0kv
 FMApZcDsI0D5mQvSv3Yo6236Nji7Fpf7xVxbHLj0yEMSUrQoCn/fzRCWcI1Tu1JT
 ezYf7bOlR1pT3jsmjQmcCCPpOHGEqyepQmWxxahoDzBpsW6PFrTo3d/vXFkS50OQ
 ==
X-ME-Sender: <xms:ZX_OWlpAVM6HzqzMyZScXeIz8AT9da3cl9rcbpmu5rYo0UC82dfsSg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4E41BE5087;
 Wed, 11 Apr 2018 17:34:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: Aaron Conole <aconole@redhat.com>, Timothy Redaelli <tredaelli@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Jan Viktorin <viktorin@rehivetech.com>, Jianbo Liu <jianbo.liu@arm.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Chao Zhu <chaozhu@linux.vnet.ibm.com>, Keith Wiles <keith.wiles@intel.com>
Date: Wed, 11 Apr 2018 23:34:27 +0200
Message-ID: <22739292.VNXgVMcpcx@xps>
In-Reply-To: <20180402182434.14045-1-aconole@redhat.com>
References: <20180322153549.17910-1-aconole@redhat.com>
 <20180402182434.14045-1-aconole@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] eal: abstract away the auxiliary vector
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Apr 2018 21:34:30 -0000

Anyone to review, please?

02/04/2018 20:24, Aaron Conole:
> Rather than attempting to load the contents of the auxv directly,
> prefer to use an exposed API - and if that doesn't exist then attempt
> to load the vector.  This is because on some systems, when a user
> is downgraded, the /proc/self/auxv file retains the old ownership
> and permissions.  The original method of /proc/self/auxv is retained.
> 
> This also removes a potential abort() in the code when compiled with
> NDEBUG.  A quick parse of the code shows that many (if not all) of
> the CPU flag parsing isn't used internally, so it should be okay.
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>