DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error
@ 2016-10-17 10:51 Jasvinder Singh
  2016-10-17 12:40 ` Dumitrescu, Cristian
  0 siblings, 1 reply; 3+ messages in thread
From: Jasvinder Singh @ 2016-10-17 10:51 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu

This patch fixes the misleading indentation error on compiling ip_pipeline
app with gcc v6.2.1.

Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
 examples/ip_pipeline/app.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
index 564996e..f8b84e0 100644
--- a/examples/ip_pipeline/app.h
+++ b/examples/ip_pipeline/app.h
@@ -1152,7 +1152,7 @@ app_tap_get_writer(struct app_params *app,
 	struct app_pktq_tap_params *tap,
 	uint32_t *pktq_out_id)
 {
-	struct app_pipeline_params *writer;
+	struct app_pipeline_params *writer = NULL;
 	uint32_t pos = tap - app->tap_params;
 	uint32_t n_pipelines = RTE_MIN(app->n_pipelines,
 		RTE_DIM(app->pipeline_params));
@@ -1168,10 +1168,11 @@ app_tap_get_writer(struct app_params *app,
 			struct app_pktq_out_params *pktq = &p->pktq_out[j];
 
 			if ((pktq->type == APP_PKTQ_OUT_TAP) &&
-				(pktq->id == pos))
+				(pktq->id == pos)) {
 				n_writers++;
 				writer = p;
 				id = j;
+			}
 		}
 	}
 
-- 
2.5.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error
  2016-10-17 10:51 [dpdk-dev] [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error Jasvinder Singh
@ 2016-10-17 12:40 ` Dumitrescu, Cristian
  2016-10-25 14:32   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2016-10-17 12:40 UTC (permalink / raw)
  To: Singh, Jasvinder, dev



> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, October 17, 2016 11:51 AM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error
> 
> This patch fixes the misleading indentation error on compiling ip_pipeline
> app with gcc v6.2.1.
> 
> Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
>  examples/ip_pipeline/app.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error
  2016-10-17 12:40 ` Dumitrescu, Cristian
@ 2016-10-25 14:32   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-10-25 14:32 UTC (permalink / raw)
  To: Singh, Jasvinder; +Cc: dev, Dumitrescu, Cristian

> > This patch fixes the misleading indentation error on compiling ip_pipeline
> > app with gcc v6.2.1.
> > 
> > Fixes: 3f2c9f3bb6c6 ("examples/ip_pipeline: add TAP port")
> > 
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > ---
> >  examples/ip_pipeline/app.h | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-25 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 10:51 [dpdk-dev] [PATCH] examples/ip_pipeline: fix gcc v6.2.1 build error Jasvinder Singh
2016-10-17 12:40 ` Dumitrescu, Cristian
2016-10-25 14:32   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).