From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>,
dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: add support for testpmd-compliant flow rule dumping
Date: Fri, 2 Jul 2021 13:20:50 +0300 [thread overview]
Message-ID: <22746461-398e-21a4-29e2-40ab72d94e5f@oktetlabs.ru> (raw)
In-Reply-To: <97d647fc-011a-d99b-4cf6-c2d35350a8bc@intel.com>
Hi Aman,
On 6/14/21 3:42 PM, Singh, Aman Deep wrote:
> Hi Ivan,
>
> As a suggestion, can we add a check for debug log_level in
> "rte_flow_snprint" itself.
I see the reason, but I think it a bad idea to put the check
inside the function. If calling function cares, it should do
the check.
> So we can avoid CPU time, in cases where we don't want these logs.
[snip]
prev parent reply other threads:[~2021-07-02 10:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 8:25 Ivan Malov
2021-05-30 7:27 ` Ori Kam
2021-05-31 2:28 ` Stephen Hemminger
2021-06-01 14:17 ` Ivan Malov
2021-06-01 15:10 ` Stephen Hemminger
2021-06-01 14:08 ` Ivan Malov
2021-06-02 13:32 ` Ori Kam
2021-06-02 13:49 ` Andrew Rybchenko
2021-06-03 8:25 ` Ori Kam
2021-06-03 8:43 ` Andrew Rybchenko
2021-06-03 9:27 ` Ori Kam
2023-03-23 12:54 ` Ferruh Yigit
2021-06-02 20:48 ` Stephen Hemminger
2021-06-14 12:42 ` Singh, Aman Deep
2021-06-17 8:11 ` Singh, Aman Deep
2021-07-02 10:20 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22746461-398e-21a4-29e2-40ab72d94e5f@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).