From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5C58A04A3; Tue, 16 Jun 2020 13:44:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13AF81BF59; Tue, 16 Jun 2020 13:44:21 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id D0C7D1BF58 for ; Tue, 16 Jun 2020 13:44:19 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id E45F058020A; Tue, 16 Jun 2020 07:44:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 07:44:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= FwBu/U1TdirwGP+cPD6vFFtm3njIKC5AyTWhNfJrieI=; b=QVYKhMnA9LPRZYNW Syk2bUt334jkONQMIiiJ69tkbi7/vJ0eN4LPvhKhM+aCBCVNE7wIWZ61LTMIWAu4 zVYM0h0TflyQgwyNTvHa9qZyMMquCTG73FuioV9k7DD/fzlPmW84QWlNhObYDSJT ZRWZzbloEuA4nWSZSQ8HhiSVjsPtLA74vwzMMT37me/9IsybXUT2N8sLWprIxIRe Zlph2cDvO4IX2cSGRcl6bZT5tBxEOveHK3z1au7i2FV+MrH6FDYY12tTYsvaOvhr lmWQRwQEQ1wG/r5Q8gEPvWOgGIrQnSNjB3IUBz5rrt2/dWFvKHw3ADSxG0wj/lVY IYhivA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FwBu/U1TdirwGP+cPD6vFFtm3njIKC5AyTWhNfJri eI=; b=R0/aGp8QztdRV//4KhdB7nES8kHmLUDlNEFoyOurZVq0QlPxRW9pMwjFZ TmiiIEvodwO1+IREnW5+FaliMfMZtTf76ij4HBR/1cb2JsiRCuBrz01JwUGiXwgH rjPFDf6Bt7mAi1CjiXgXOMXYgBD4EspYlywk5/hqvSP6sUfyooyFoT2LIvUtvasO LfOylaUjRoSvyUZrPLFmOglvVE2PJDXM8KWUotUg7sbEJu2CLQ3Z3JZqqdDa3iJs hq/cgQ2MwyxWytNeKC45ZAlrv8fII/kp057xS4NUSY8TRLVyRzFCGSZqBt7INv+l N8frUhm0DrUW6I/FHhPJkz/L/1sHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepgeejfffhhfeghfetveffgeffteelveekhffghfefgedvleeuveet fffgudelvefhnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeejrddufe egrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0BB3B30614FA; Tue, 16 Jun 2020 07:44:14 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman , Dmitry Kozlyuk Cc: dev@dpdk.org, "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , Fady Bader , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" Date: Tue, 16 Jun 2020 13:44:12 +0200 Message-ID: <227473751.AKOPhv2c1H@thomas> In-Reply-To: <20200616122613.3aa4c836@sovereign> References: <20200601093818.5420-1-talshn@mellanox.com> <18516284.rRsmoNJoJ4@thomas> <20200616122613.3aa4c836@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2020 11:26, Dmitry Kozlyuk: > Thomas Monjalon wrote: > > 16/06/2020 10:33, Tal Shnaiderman: > > > > 01/06/2020 11:38, talshn@mellanox.com: > > > > > From: Tal Shnaiderman > > > > > > > > > > Export needed eal functions used by the lib. > > > > > > > > > > Signed-off-by: Tal Shnaiderman > > > > > --- > > > > > --- a/lib/librte_eal/rte_eal_version.map > > > > > +++ b/lib/librte_eal/rte_eal_version.map > > > > > @@ -394,4 +394,5 @@ EXPERIMENTAL { > > > > > rte_mem_unmap; > > > > > __emutls_v.per_lcore__rte_errno; > > > > > __rte_trace_mem_per_thread_alloc; > > > > > + __emutls_v.per_lcore__lcore_id; > > > > We already have per_lcore__lcore_id and per_lcore__rte_errno > > for Linux and FreeBSD. > > The prefix __emutls_v. for MinGW looks wrong. > > If it is really required, it should be added automatically > > in my opinion. > > I think we can do it in buildtools/map_to_def.py > > by adding this prefix to per_lcore__ when required. > > MinGW doesn't use .def, it's for link.exe only (used by Clang). To my > understanding, multiple .map files can be used [1]. The "overlay .map" for > MinGW can then be generated from the generic .map by a separate script. > > [1]: https://github.com/PlushBeaver/dpdk/blob/windows/lib/meson.build#L174 Yes please generate a map with the fixed prefix. It can be done in a script similar to buildtools/map_to_def.py, right?