From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E0D1A288C for ; Thu, 26 Jul 2018 23:00:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7B3D421B13; Thu, 26 Jul 2018 17:00:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 17:00:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nJ3rbQQfk579SQcgq7qwvrkUY8 aCUYQD0coyuY6m+oA=; b=Y+kqwBsMeda+YVpqP+OjA5eMeDO9qrvZC2AKmiL2bI ONIUZh7LOc0zRIYrC3JtRskLISFAChZm2F/ZqBb0Qh79xNgGob/snBdSA8t0GGoL uFzkEZyNPkfPSUHCPoyBu8FGdrUJn54HXdV8F6cOAGKFzaXMQX0+tkeWEKUXq6lQ M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=nJ3rbQ Qfk579SQcgq7qwvrkUY8aCUYQD0coyuY6m+oA=; b=G5TIsjd8uv+djY/Q8e0j0Z s+mjqX77Uq391pxAPPCPhNIsBDyiW33IK4eR3gb2Rj+5jeTF/cxXdS2bBAgT/XZF uU4TRhZrQr0BSE366iRrpGZM/4pDOn4PeIXFVrYGWP0huQFCJb4crQXS60LbVxBt f2cX8DQo/rIrr8kdwi/AHfem6xK3GgenXfhtU8sW+X1VFWBeYcsd+eXmd2Xnqp+S Hi+LQG8CauljzLDD0uOGpEHoY1F4muhqdwIQVK/k1pN9mZRakheC1FLnQxVeD8KV MVO7QzrqKMOILZvoP7D5sbkREa53wJHVFdYUUcxDK10qHtGq5FpPHIzbrhQC+X2g == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C86991025D; Thu, 26 Jul 2018 17:00:30 -0400 (EDT) From: Thomas Monjalon To: Arnon Warshavsky Cc: dev@dpdk.org, "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" Date: Thu, 26 Jul 2018 23:00:26 +0200 Message-ID: <2274773.jc5eBGUB0q@xps> In-Reply-To: References: <1531741077-5513-1-git-send-email-arnon@qwilt.com> <5378502.1ef9rKBE6e@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 21:00:33 -0000 26/07/2018 22:57, Arnon Warshavsky: > > > + if [ $? -ne 0 ] ; then > > > + ret=1 > > > + fi > > > + printf '%s\n' "$report" > > > > You are printing the report, no matter of the result? Why? > > Is it because a warning does not return as an error? > > > There is maybe an improvement required here. > > > > Yes this is indeed the reason. > Sticking to a simple success/fail in the return value with the price of > printing an empty string in the case of no-warning seemed better than > handling multiple (>2) return codes . > Do you have a preferred way here? My preference is to return an error if there is a warning. The script itself must return an error code. Thank you