From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id EEFEE5587 for ; Fri, 15 Jul 2016 23:28:44 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id i5so45546358wmg.0 for ; Fri, 15 Jul 2016 14:28:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=PvopoPiSiadr0x6+E+57GSKPScaJaQUB4XFgWRCbjgY=; b=kOWfF3Vzecw+P9mfKfo406V3eDhCP2IlfVaz3+VxffM0BTz+goJb+T0TJ2rvS7V5sT h10YnN4Sj6lqdu4exAPxh6LK8dGh3gDS7OEUjbKthM1LG/tUPcUM4fB8bhY18aTCiKVn dqD6ExazCrbIL5Uh+Eu+6oqn2fhG+BS7PhjoM7AqNvLbJykDz5OHR1bJlhRWuW0DoYAs dINVHYLsP5IQfP+QCgA9V3VTUmfMe/HxZc+wFDYYe8plvlb5VhD2P7PwrbPNoffHmKfi rp7yxtAu/EhJE0z0s9xSFqEouPXLcEjkUujZnlMZD7A8qMylRyo2eF+s9WU/Y+2Uw9Ku E79Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=PvopoPiSiadr0x6+E+57GSKPScaJaQUB4XFgWRCbjgY=; b=RsAmhvc2wyvPpxFB1lrtVTEtBWrctOv8xzAM7KKS5cd9nwCZhSUeApmrK4e5x4gm2G 14tmDpBBlyj6OST2qNZIw7ytwbDNFVfJMkqh7ID4CXySg2EzvWeBJr7X9CLqKCXloYVR /oA2vLwSRl4E0MPaozx3E5dQOqa8XxjiK2u2VVEALWZU/sNUZzl8qf3/PNlbVnOP3ZR8 ITzTaYHHo3Ofvj4gZ4QuJEteylnWMaHrB9L8JPN0ZIdS3bXaROQNhiwwrOfVsH12HfDP gL02KAY1aQ8Czruq2vmZSXGy/bSFsM2HAcztS9RX+LoC8vq5PxUeG1x1iRlw+5uBNftr /9vQ== X-Gm-Message-State: ALyK8tJa0I8D31X6L3TELWLhvTqnluhBpADh4mbix62fdUzvGeKLtaqQMPGm8phO9HRS9RLa X-Received: by 10.28.87.3 with SMTP id l3mr43308822wmb.71.1468618124823; Fri, 15 Jul 2016 14:28:44 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i195sm926170wmg.1.2016.07.15.14.28.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 14:28:44 -0700 (PDT) From: Thomas Monjalon To: John Daley Cc: dev@dpdk.org, bruce.richardson@intel.com Date: Fri, 15 Jul 2016 23:28:43 +0200 Message-ID: <2276333.lY5HiAz0Gq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1468185330-19713-1-git-send-email-johndale@cisco.com> References: <1468185330-19713-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/enic: fix crash when changing number of Rx or Tx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 21:28:45 -0000 2016-07-10 14:15, John Daley: > The check that all Tx and Rx queues were set up was not > adequate when reconfiguring with a different number of > queues. Only the number of completion queues (CQs) was > being used to make the determination, but the CQ array > is shared between the underlying Rx and Tx queues. > > Check that the internal Rx, Tx and CQs are all set up > before completing port configuration. > > Fixes: fefed3d1e62c ("enic: new driver") > > Signed-off-by: John Daley > Reviewed-by: Nelson Escobar Applied, thanks