Re: [dpdk-dev] [PATCH v4] mempool/octeontx2: add devargs to lock ctx in cache

[Thomas Monjalon <thomas@monjalon.net>]

01/05/2020 12:21, Pavan Nikhilesh Bhagavatula:
> >Subject: [dpdk-dev] [PATCH v4] mempool/octeontx2: add devargs to
> >lock ctx in cache
> >
> >From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> >Add device arguments to lock NPA aura and pool contexts in NDC cache.
> >The device args take hexadecimal bitmask where each bit represent the
> >corresponding aura/pool id.
> >Example:
> >	-w 0002:02:00.0,npa_lock_mask=0xf // Lock first 4 aura/pool ctx
> >
> >Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >Acked-by: Jerin Jacob <jerinj@marvell.com>
> >---
> >
> >Depends on series
> >http://patches.dpdk.org/project/dpdk/list/?series=5004
> >
> > v4 Changes:
> > - Mark `otx2_parse_common_devargs` as __rte_internal.
> 
> Ping @thomas 

Now that __rte_internal marking was merged,
this patch is candidate for -rc2, but...


> >a/drivers/common/octeontx2/rte_common_octeontx2_version.map
> >b/drivers/common/octeontx2/rte_common_octeontx2_version.map
> >@@ -45,8 +45,21 @@ DPDK_20.0.1 {
> > 	otx2_sec_idev_tx_cpt_qp_put;
> > } DPDK_20.0;
> >
> >+DPDK_20.0.2 {
> >+	global:
> >+
> >+	otx2_parse_common_devargs;
> >+
> >+} DPDK_20.0;

Why are you adding the symbol both in 20.0.2 and INTERNAL below?


Also, that's a pity you did not take time to convert all the symbols
of this internal library to __rte_internal.


> >+
> > EXPERIMENTAL {
> > 	global:
> >
> > 	otx2_logtype_ep;
> > };
> >+
> >+INTERNAL {
> >+	global:
> >+
> >+	otx2_parse_common_devargs;
> >+};