Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

[Thomas Monjalon <thomas@monjalon.net>]

05/02/2018 11:06, Burakov, Anatoly:
> On 02-Feb-18 5:08 PM, Thomas Monjalon wrote:
> > 02/02/2018 11:31, Burakov, Anatoly:
> >> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote:
> >>> 01/02/2018 18:04, Burakov, Anatoly:
> >>>> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote:
> >>>>> 17/01/2018 12:15, Anatoly Burakov:
> >>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>>>
> >>>>>> Fixes: c7e4a134e769 ("test: verify bitmap operations")
> >>>>>> Cc: pbhagavatula@caviumnetworks.com
> >>>>>>
> >>>>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>>>>
> >>>>> I think you missed to report some previous acks in this series.
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>> Which ones were there? I can only see two new acks for v3 from Olivier.
> >>>> Everything else seems in order, unless my email client is lying to me :)
> >>>
> >>> There are some acks from Cristian.
> >>>
> >> They are all already in the patchset.
> > 
> > Oh, I didn't see them because they are at the beginning or middle of
> > the message. They should be in chronological order after your Signed-off.
> > 
> > 
> 
> That's a bit hard to do since my signoff is generated by 
> git-format-patch rather than manually, but OK, i'll see what i can do. 
> Apologies for the confusion.

Your signed-off should be generated when creating the commit:
	git commit -s
Then you add acks by updating the commit:
	git commit --amend