From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 002F8199B4 for ; Mon, 5 Feb 2018 11:25:46 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4EEB520D79; Mon, 5 Feb 2018 05:25:46 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 05 Feb 2018 05:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zE/R+WhVq3Kx4ZhEPklzo4Fnkn iSOzEX/jqrmSCGLzw=; b=iYijZ/Jw0FXl1oOd/mcTpKq8+5NbFyAIohRJG7hbsS mpYjw9bvCvVBuu9zWi2ELLD2gsfPExM12P5NgSe9W4kI8fwo5WwTyTzCk5StXltQ mJNxgs2wfQh6Vr4pzMhvGMG0XF0fxQZJna8OxVlfy1XopsHlK1w3JQFFOud2y/Lf k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=zE/R+W hVq3Kx4ZhEPklzo4FnkniSOzEX/jqrmSCGLzw=; b=jrf23K47VTslWMorg92JOs 4S+ZKmJ0VvlVf/C9+yHYskH57nTasWFy3R+LX/Pwg21ymEfnLDYJyy7ct/n4ddos mA+U0xClbT7yPMB3OchNIX5IYacTYnTanDFusTY0d80XbH2pQeYD03d8pWl3LACS hqB++7LpH++/ghMRVsGQF9nEhKiFcHJOjCzC+xikfk5CzkBHTtFeEbRFf1IDNWoo iNKATF2Ezwqn/EfTMrrveU3xDpDFRtnEvSAqAoZD6VYGX7+iyihJh8xkxG5xYN/6 Vgkyg6QVRRlaPAU6dFSzQubs5JwEOrHPSjKwmTuDEV76kYZACNHDIsQ3u3x44qpA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F240E7E0FD; Mon, 5 Feb 2018 05:25:45 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Cristian Dumitrescu , pbhagavatula@caviumnetworks.com Date: Mon, 05 Feb 2018 11:25:42 +0100 Message-ID: <2278506.lDYVRKTEsi@xps> In-Reply-To: References: <9d5a3bc7a779b2dddab4256aa3e0631737861f98.1513867589.git.anatoly.burakov@intel.com> <2278700.hXEWzmFphA@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 10:25:47 -0000 05/02/2018 11:06, Burakov, Anatoly: > On 02-Feb-18 5:08 PM, Thomas Monjalon wrote: > > 02/02/2018 11:31, Burakov, Anatoly: > >> On 02-Feb-18 9:08 AM, Thomas Monjalon wrote: > >>> 01/02/2018 18:04, Burakov, Anatoly: > >>>> On 01-Feb-18 12:10 AM, Thomas Monjalon wrote: > >>>>> 17/01/2018 12:15, Anatoly Burakov: > >>>>>> Acked-by: Cristian Dumitrescu > >>>>>> > >>>>>> Fixes: c7e4a134e769 ("test: verify bitmap operations") > >>>>>> Cc: pbhagavatula@caviumnetworks.com > >>>>>> > >>>>>> Signed-off-by: Anatoly Burakov > >>>>> > >>>>> I think you missed to report some previous acks in this series. > >>>>> > >>>>> > >>>>> > >>>> > >>>> Which ones were there? I can only see two new acks for v3 from Olivier. > >>>> Everything else seems in order, unless my email client is lying to me :) > >>> > >>> There are some acks from Cristian. > >>> > >> They are all already in the patchset. > > > > Oh, I didn't see them because they are at the beginning or middle of > > the message. They should be in chronological order after your Signed-off. > > > > > > That's a bit hard to do since my signoff is generated by > git-format-patch rather than manually, but OK, i'll see what i can do. > Apologies for the confusion. Your signed-off should be generated when creating the commit: git commit -s Then you add acks by updating the commit: git commit --amend