From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 22EB71B579 for <dev@dpdk.org>; Thu, 11 Oct 2018 13:48:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A5A7420B52; Thu, 11 Oct 2018 07:48:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 11 Oct 2018 07:48:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0BfJTqC8+BK/tannxTHB5vp1p4IHlQHEKbmTgb7BJtw=; b=g9egWvSBLs8O FzsO1wzn8leN3yE/vWpcPbgPUNLBr4GHwQxTNw52UwwTJJROVU6DTc9PVuyEeb1D Sc4VIosGZg/Z0Gtx1eobaXKJ5adiUBZ5VkqngYnqjjZS3gG5mOMtoC4w0ChntjnN uBqKswwDiniombaIiuJiPLYiLqC5H+s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=0BfJTqC8+BK/tannxTHB5vp1p4IHlQHEKbmTgb7BJ tw=; b=uujevYne9Snsgk3ijKhLHq0HBTfBuwI+a0W71l7u7b+PeU49frG2kHfWP GaRB2fD++c2wbhED7gLl4n8ZmcgnUTHg/yHFrN2aCldk40uLf9cr9uWhsGemU5XG WzB1f7lyJ/BLf1w+cp9gvz4c0JN18ewmdQqip/pVmsRriUk4hbhxWRHQjto69Z6e ztQ7q+39/xxYqwMp8+9Ecyop1FSOYOhw2X1P5/fM2hPm3aqr0veregV1IGvBCe36 kwJ+y7AMYd+rL6CCzRKr31pm2nL5MbQonRtoD2LVminzDjDIDT/YzBEG8qGitZ/W WMfp56gZozjEhBXSQC+miuMpKV47g== X-ME-Sender: <xms:oji_W_6lt_TfOR6rY47xewk8FGaJa7rGTge6hih_Nn5PIInvzpHyBw> X-ME-Proxy: <xmx:oji_W3H8okVrebaUhOlTpKwQD-Rm436eci2NUjTfmyIly1kRYFPL0w> <xmx:oji_W2ZFMxtteSgLpj9HFArOtVEJkinJuT5wLhIf5zTbG20CAZ_2gQ> <xmx:oji_W3Q2C4zoReIRYKtqfRRquDq5z5_Lav2JyUASkhkUSlbOlMadgA> <xmx:oji_W6Dbdyqu9n-Y1j26f0O1WSECGPt_PB2CGT9eLeowVPCy0zGYjg> <xmx:oji_W56g7JZr69t6YPWqGh2I00jgdxUkUWOshJ4VYxwWKnD7dAeG0A> <xmx:ozi_W_ir8XVR3rwG_8LK09iRTFfxFzzWJgNcjc6oViHgFC6HRB-4pQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D9436102A0; Thu, 11 Oct 2018 07:48:49 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Stephen Hemminger <sthemmin@microsoft.com> Date: Thu, 11 Oct 2018 13:48:48 +0200 Message-ID: <2280183.FyIV3bEMkT@xps> In-Reply-To: <2919e34a-f943-80fc-d2f0-d1c53fde0cae@intel.com> References: <20180914153019.8983-1-stephen@networkplumber.org> <2919e34a-f943-80fc-d2f0-d1c53fde0cae@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix refcount if open returns error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 11 Oct 2018 11:48:52 -0000 26/09/2018 19:20, Ferruh Yigit: > On 9/14/2018 4:30 PM, Stephen Hemminger wrote: > > This fixes the problem of reference count leak if > > igbuio_pci_enable_interrupts fails. > > > > Also, replace mutex and integer with a kernel atomic counter. > > This is standard pattern for kernel devices. > > > > Fixes: 19685d5aa79c ("igb_uio: allow multi-process access") > > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com> > > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied, thanks