From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 912D49955
for <dev@dpdk.org>; Mon, 31 Jul 2017 22:12:49 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 0750420849;
Mon, 31 Jul 2017 16:12:49 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Mon, 31 Jul 2017 16:12:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=7b6+r6BuiZlwZf0
dw5+icl3o+CDH84YR4LJsZA9bMRY=; b=pnPLZ3QL9YOVVWvpqvUln424BF/oytF
EtC4F5MeKCRlc3CDHvGTr45N+uOUQpc0hklftwK7VuHrYV/hFe+0Qgs0ZLkq5Hw4
A8dXJ3j7pHO2J0PYeVreGRhjpeoQkI8qxIGe1VExFzlKbPFpK4P6xrsBojdIkzvq
8kA4PA+YgDkY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=7b6+r6BuiZlwZf0dw5+icl3o+CDH84YR4LJsZA9bMRY=; b=jRGmFpDh
4BCXjKQF35LoUybdKowa2S/LOF3tKafWGSx1TmgigqQJBSa3nmR0vDxLB1ZdSBoP
zRRluabuAlFL0QN33XT+DVCm9llnw0gpMcjHPnmqNLaW10nfV7Ey+gSqKExOtWx1
5AXyZr7OXedKdpUOQaQZMj5O/QGuk0YyBMeY6zA3RUfDy+e8+q8BXPdjfFElmP3v
Oayu+azX3jUEveerZBTKlKHPrdrG9FN+ggnouBKHo8qKH+XxSUqV1e/zGDaIKOuH
TbjzqklWwDD9ARM0+tAcyY6VYJ3K+BUqAseo7eAztnVlVFTnax2usjlwIx0VukOP
Luaq2pscETD32A==
X-ME-Sender: <xms:QI9_WXfYHLAPZZ92tni0Ex6W0ko-BQs7T2qrbzVc3Om2mnQoNODOWQ>
X-Sasl-enc: CkD8Q7EgmbkRrLLCiNRY3B0qEd+9FKdpBthakl1twxW+ 1501531968
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id A01367E432;
Mon, 31 Jul 2017 16:12:48 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com
Date: Mon, 31 Jul 2017 22:12:47 +0200
Message-ID: <2283012.f371VpG1HL@xps>
In-Reply-To: <1501519135-122347-1-git-send-email-harry.van.haaren@intel.com>
References: <1501516707-87024-1-git-send-email-harry.van.haaren@intel.com>
<1501519135-122347-1-git-send-email-harry.van.haaren@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] service: fix shifts to operate on 64 bit
integers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 20:12:49 -0000
31/07/2017 18:38, Harry van Haaren:
> This commit fixes shifts to an integer (1 << shift) which
> is assumed to be a 32-bit integer. In this case, the shift is
> variable and expected to be valid for 64-bit integers. Given that
> the expectation to work with 64 bits exists, we must ensure that
> the (1 << shift) one in that formula is actually a uin64_t.
>
> The UINT64_C() macro portably adds the correct suffix to a constant,
> informing the compiler that the value is to be assigned 64 bits.
>
> The issue would only manifests when there were greater than 31
> services registered.
>
> Fixes: 21698354c832 ("service: introduce service cores concept")
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks