From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1B88F1B237 for ; Tue, 31 Oct 2017 19:21:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 76AE120D1A; Tue, 31 Oct 2017 14:21:20 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 31 Oct 2017 14:21:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=hAnUuwcfBFkccoJ6i00iBzwVfT dtCQArK1FH50lo7E8=; b=qN4J6tl16GCBj7usByT5XRJibUE471lGDsZIsYhBPh w4Y/OAZZV4BMF+vJtay5+hb9bMGOHSg7rYTR3TaFyoYz3qh1o+wd1aXo57f7lNHo 5j2WS3wMfGsgJAzoijrp8AQU6HixJODD6kszZznYg6bD6n/CMyYr3LMBuJ9MbrLK 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hAnUuw cfBFkccoJ6i00iBzwVfTdtCQArK1FH50lo7E8=; b=j53fSzJmZsKUTtdEiiXMDr wjTiOWfqoTXwDv+qkUMlenkgrJ6u3DBhTigVOdaVx1noYstDmtMEZx4Q02BYryZi qrYJ6nSGDcmO7ZEm5dQNtDErsBTPgsBNEkA3LeVu6ADtc3LvpmNUZGDT78aFWs4b MpSV56PlCWtecqJed/AHSJp6DAQkgfvLdABhMZCcUrsbr13ALLtFVNM32zg2L3WX mT64g38/CwIvqO37Pp1N7b066R9pbZwkzdDx0tvwMR7bWUJbrKtiHYKgO8U4yiGA Lm/wbxmc9y3yXcO3VScbGGu/jWd4ER7lNEelbSu9ARbIctZo8PtXEw//cpLTUpJQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0540724E76; Tue, 31 Oct 2017 14:21:20 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Jerin Jacob , Gaetan Rivet Cc: dev@dpdk.org, Bruce Richardson , Anatoly Burakov Date: Tue, 31 Oct 2017 19:21:19 +0100 Message-ID: <2283187.vDqOxjlXm0@xps> In-Reply-To: <20171031120338.GA6052@bricha3-MOBL3.ger.corp.intel.com> References: <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com> <20171030223227.8852-1-ferruh.yigit@intel.com> <20171031120338.GA6052@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] bus/pci: fix vfio mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 18:21:22 -0000 31/10/2017 13:03, Bruce Richardson: > On Mon, Oct 30, 2017 at 10:32:27PM +0000, Ferruh Yigit wrote: > > Revert back to using VFIO_PRESENT as a marker to enable compilation > > of VFIO-related segments. > > > > VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and > > kernel version support check. > > > > eal_vfio.h VFIO_PRESENT related check ordered to be compatible with > > rte_vfio.h one, no functional modification. > > > > Fixes: 279b581c897d ("vfio: expose functions") > > > > Signed-off-by: Jerin Jacob > > Signed-off-by: Gaetan Rivet > > Signed-off-by: Ferruh Yigit > > --- > > v4: > > > > * Alternative to v3, not superseding it, need to decide which one to > > get. This one: > > * fixes vfio for new kernels > > * fixes build for old kernels for vfio enabled in config case > > * print warning if vfio enabled in config but not supported by kernel > > > > * Independent from this patch, following may need fixing later > > * Kernel version check for vfio is broken for RTE_KERNELDIR > > * Kernel VFIO support check can be improved > > --- > > drivers/bus/pci/linux/pci_init.h | 2 +- > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > lib/librte_eal/common/include/rte_vfio.h | 14 ++++++++++++++ > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 1 - > > lib/librte_eal/linuxapp/eal/eal_vfio.h | 14 ++++++++++---- > > 5 files changed, 26 insertions(+), 7 deletions(-) > > > Hi, > > just to confirm that applying this patch fixes DPDK on my system at > least. > > From the discussion, I understood that this was a "compilation problem", > but in practice it manifests itself as compile working ok but your app > won't work with ports bound to vfio-pci. So please apply some fix for > this soon. > > Thanks for the work on this, all. > > Tested-by: Bruce Richardson Applied, thanks