From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 962DAA0528; Sat, 11 Jul 2020 17:12:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53AB81D960; Sat, 11 Jul 2020 17:12:01 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 5211C1C2A3 for ; Sat, 11 Jul 2020 17:11:59 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EC63FC53; Sat, 11 Jul 2020 11:11:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 11 Jul 2020 11:11:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= nKtCF6yFZ7Ttbqww1lcalv10r28zHetgTnrPTWtTsk8=; b=eHexaE1QS+kDlqsi WV0SLyJtyG6wgBHc8SSH4ePXXnb02wCBk27+Pn6ZYmxoHcGCxsID72tN85806dm6 BI6rsMV1nutExH4N+pgohXcTToqeTpz+ghabs+5r748dDFlDLQjICMh4aekZyD/h SOdiRsB1cohh5uu2w3H1E+ztOyN9k4auKEofjCVWAEu2JqsIOrWDkB4nHzdrGRBa 2ttA892N9kYCNL7Cl6gmR7mSPkLAmxsFJ7Y4iidwD5OURshnOCnHMBqGwQPC9vF4 5zmZohky865ht0IdWolMQx87TX7bBc3MqZhZzMM18zob2EJeV3nNue7wrVFjhOsw 1ChGWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nKtCF6yFZ7Ttbqww1lcalv10r28zHetgTnrPTWtTs k8=; b=o0pxZpu6l0/qRTzsa7RkFDcEWZPMnw0e6laPjcwdfyVIvmrCoSf9awANw P72FjWcWnfSbEXgJcUA64H5euRs2IlVraoZLgh90wD1vb/kjK3DdPij/82G59cvi 3kwRgRNGA+KD2jWfuKCB4boWY30fiBaLcDF/xxTk8zFQtE5dd0BhETqM/42Prypf 8aHG169B38qLHi+ytKjJsYI5D8Bb9LHl9nasyiVnhPh8p/X626zsBcsZ7iHCt9u0 xoWu6wGTv49YEQWIY/xHMoWnsmGbpMxdgRHpxFUYPUXmFf+pFlqwLlJMgJ9lqBTb R9NA5RnlkDzzRi00ADW9aa4x3DGWw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvdefgdekjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E090306005F; Sat, 11 Jul 2020 11:11:54 -0400 (EDT) From: Thomas Monjalon To: Lukasz Wojciechowski Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com Date: Sat, 11 Jul 2020 17:11:52 +0200 Message-ID: <2283396.fTMGzKxhym@thomas> In-Reply-To: <20200709134823.9176-1-l.wojciechow@partner.samsung.com> References: <20200422214555.11837-1-l.wojciechow@partner.samsung.com> <20200709134823.9176-1-l.wojciechow@partner.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/4] introduce global debug flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/07/2020 15:48, Lukasz Wojciechowski: > This set of patches introduces a global rte_debug flag for dpdk. > This will allow easy switch to debug build configuration using a single > flag. In the debug mode a RTE_DEBUG macro is defined to 1 > and for every enabled to be built library a RTE_DEBUG_{library name} > and for every enabled to be built driver > a RTE_DEBUG_{driver_class}_{driver_name} is also defined. > These macros can be used to place a debug code > inside #ifdef #endif clauses. > > The following requirements were discussed on the mailing list: > 1) The global debug flag is required to enable all the sanity checks > and validations that are normally not used due to performance reasons > > 2) The best option would be to have a single flag - not to introduce > too many build options > > 3) This option should be separated from meson "debug" option > (used for build with symbols) and can be called "rte_debug" > > 4) The currently existing DEBUG macros should not be replaced with > a RTE_DEBUG macro. This would allow to still enable them using > CFLAGS="-D..." to test a single module (library, driver). Please can we clarify this point? You mean not replacing driver macros with the global RTE_DEBUG? But we agree (next point) to replace existing macros? > 5) Currently existing options' names should be standardized > to RTE_DEBUG_{library/driver name}, so they can be automatically enabled > when rte_debug is set. Standardized names would allow easy usage > in other modules. > > 6) The debug functionality should be encapsulated in: > if (rte_log_can_log(...)) { > ... > } > for possibility to be filtered out in runtime. > > > Because of the hot discussion of v1 version of patches, I limit > the v2 version to mbuf library changes only, to see how it will impact > the performance with rte_log_can_log usage and to get opinions. > > v3 contains mbuf performance tests, which might help dpdk developers > community to decide if drop of performance related to rte_log_can_log > can be accepted. > > If agreement is reached, next steps would be to follow changes > in other libraries and drivers. If I understand well, it makes no sense to apply this v3, without having the rest of the code converted?