From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id EAF515937 for ; Fri, 18 Mar 2016 14:56:29 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p65so70084493wmp.1 for ; Fri, 18 Mar 2016 06:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=c4c8shf87WJsJ2AsLXgHQOBukul6TzTq6nce5Hck2Cs=; b=jz3dreWi+8UIRI9eczDpO6jXvmZIeWniNgWlYpe5s0117TGJoWTIBZjZwfYsKMSXie kzCEWVSaoXNzYzHZ9lcsBeGiAXkaVfZ8nZTqHvPUnoir90o0ZS2IroZX9DJ+78VtfnfU vaaBhFO9C71RENsDqenbhpEC4GNeku5K/R4uA2lSmKoQRisgmSHqK5VLxevQ3tF7J3Xn 8QVfTQabP0bnHpBjXisjafi0JsH+ZkA/fzFZ6poKFqvUeFxeMK4n1oSqJJ2c/+H2KLrc 1rGnKNYbzRLY7a3jVmj3AFEQ747J4L0Dt9AioURPc/N5bq9zmJ63L+tz3jHbD9LsMcZm nGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=c4c8shf87WJsJ2AsLXgHQOBukul6TzTq6nce5Hck2Cs=; b=F/dlApi3bn13JmRAK/dPnH+itgpjV3hw6ZwUiU8BSL0xYGlwMeN3M35TJO3bPHA3fB NHx3ouXbbwRfQKFqT7hM/DWm/5cC6YI4mmqU0Fv+Mn8KsD6gZ03NyUyHgf2DQSQPdn+E ohcpdO1zmiaf9lfIs/l1vD/7qANHMbdXIO3Y5j1uScJ+oz/zOIFrmQPlRWVvgnLMZ9k9 Y7mpgHy361Me14IJJwEUV++CZJ+/in+jnc/ZHveUzSYwd/UDXUvnq+cVY6QHu6fKPsGs g+iYNAuAVRdgR+j4jlMiob3RZ74ONnFl32OoFyj+Cvz+++fun5F+0A/9IBD3Xp6Xgx6c aaXQ== X-Gm-Message-State: AD7BkJJ3VZVhKsyqI8gQ5oXVPBqf8k1pMKbNFBHyAOJ60u4NBRl3s4idt5e+vE6X8ZYuSF4Q X-Received: by 10.28.88.15 with SMTP id m15mr41112114wmb.60.1458309389644; Fri, 18 Mar 2016 06:56:29 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id kj9sm7946004wjb.14.2016.03.18.06.56.28 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 06:56:29 -0700 (PDT) From: Thomas Monjalon To: Tetsuya Mukawa Cc: dev@dpdk.org, bruce.richardson@intel.com, ann.zhuangyanying@huawei.com Date: Fri, 18 Mar 2016 14:54:58 +0100 Message-ID: <2287874.v1n9VH3tqv@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458030701-11487-2-git-send-email-mukawa@igel.co.jp> References: <1458030701-11487-1-git-send-email-mukawa@igel.co.jp> <1458030701-11487-2-git-send-email-mukawa@igel.co.jp> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v12 1/2] ethdev: Add a new event type to notify a queue state changed event X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 13:56:30 -0000 2016-03-15 17:31, Tetsuya Mukawa: > This patch adds a below event type. > - RTE_ETH_EVENT_QUEUE_STATE_CHANGE > This event is used for notifying a queue state changed event. [...] > enum rte_eth_event_type { > RTE_ETH_EVENT_UNKNOWN, /**< unknown event type */ > RTE_ETH_EVENT_INTR_LSC, /**< lsc interrupt event */ > + RTE_ETH_EVENT_QUEUE_STATE_CHANGE, > + /**< queue state changed interrupt */ This comment is not really helpful. Please could you describe what is a queue state? Is it only applicable to vhost? Can we say there is a real interrupt or simply an event?