From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 3187E1E20 for ; Thu, 6 Apr 2017 16:39:31 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id t20so65581246wra.1 for ; Thu, 06 Apr 2017 07:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=g+ig88jkCefBCWXYCTs9lcNQFWZ1eZrYxA5B0YvX7kQ=; b=aKAX+yszxSSb1fzzqPLzpEsCCBzmv8X38VL/xmbqutvfac/sBpDBrDhxPWT7Asv9nT KG/E2e4D6HfndCbQiip004hcDhB4r4IZmk+/QoYUrlTzYZ3Kvv8edZmmgX92cGof2aCY W8qhKt5IXNd3kVYh9wtYirtrdAk0yVPleXniybUY+tqkleZzRGS7UtYE9qGZAWyDDKjA pTIudH7QxbxpQKYSwMUx2dDqMHM+9+sskd/xdPkad7S4aLcxJ1JZPCCVbvowVYl3avC9 LHlq9kbFrKTiKIZG4zIfCvpsGsxs/D/bURD/vByI+Zr8QSinhaXqQ+UIO1flhdnRsldM duxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=g+ig88jkCefBCWXYCTs9lcNQFWZ1eZrYxA5B0YvX7kQ=; b=d56a9xyTjGzBdeGQU3S3FEqRO2+nR8/ETc0cJHSRvsLDXWBjUuoTunvC8B1Ii54akt yCSzcv7JQkV60MlPy++pw3Dqo2yN0sJJnGv5EvS7QH6cS7YVZn4F/QAjVCs4zBFi0jxe FhaYHWaPDdaSIqO0ONwDdnR+fkUQyertrXvVfrCDnDEmF1QhTlAbfoxxNTL5Uu4ArlWE JMvu3Ke5djq9V/FTH3UEVW3Uwfp2i/9yKvueYn4qiAU883FoAKKyIK9PMb1P3W7bX80w 5pbxHvwj+MjF4cm17wDIXBjS+9cOYdZjdd7e8Y/K4ecOR5WG89HzT+w+1DGn5HGKBOCZ wjFw== X-Gm-Message-State: AFeK/H3HLgNmxmI8CK+zcE4WpIApfTdHo+w3e0kFc7aEdB+nSvk0h/82tfdIGWcM0snQ4cSX X-Received: by 10.223.167.145 with SMTP id j17mr25246709wrc.178.1491489570879; Thu, 06 Apr 2017 07:39:30 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id o9sm2692399wmd.4.2017.04.06.07.39.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 07:39:30 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Cc: dev@dpdk.org, Olivier Matz , "Wu, Jingjing" , "Richardson, Bruce" , "Yigit, Ferruh" Date: Thu, 06 Apr 2017 16:39:28 +0200 Message-ID: <2288626.lNqLql9yzM@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20170406141655.15097-1-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/i40e: disable init and driver logs by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 14:39:32 -0000 Hi Helin, Thanks for acknowledging. This mail to explain how important it is to configure his mailer. You need to quote the original mail so we can quickly find what you have replied. It is also a problem for patchwork as it creates a new entry: http://dpdk.org/dev/patchwork/patch/23300/ because it thinks it is a new patch. So your ack is not registered in the original patch entry: http://dpdk.org/dev/patchwork/patch/23298/ Please share this explanation, thanks 2017-04-06 14:31, Zhang, Helin: > > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Thursday, April 6, 2017 10:17 PM > To: dev@dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing ; Richardson, Bruce ; Yigit, Ferruh > Subject: [PATCH] net/i40e: disable init and driver logs by default > > Since "net/i40e: use dynamic log type for control logs", the i40e driver is more verbose by default, which could result in testpmd being flooded by log messages in some conditions: > > Checking link statuses... > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > i40e_dev_handle_aq_msg(): Request 2561 is not supported yet > Port 0 Link Up - speed 40000 Mbps - full-duplex > Port 1 Link Up - speed 40000 Mbps - full-duplex > Done > testpmd> i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > i40e_dev_handle_aq_msg(): Request 4097 is not supported yet > > Fix this by disabling the dynamic logs by default. It is still possible to enable them at runtime. > > Fixes: c143e5a3d9e1 ("net/i40e: use dynamic log type for control logs") > > Signed-off-by: Olivier Matz > Acked-by: Helin Zhang > --- > drivers/net/i40e/i40e_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index cb8bf2b49..86f5669f0 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12456,8 +12456,8 @@ i40e_init_log(void) { > i40e_logtype_init = rte_log_register("pmd.i40e.init"); > if (i40e_logtype_init >= 0) > - rte_log_set_level(i40e_logtype_init, RTE_LOG_NOTICE); > + rte_log_set_level(i40e_logtype_init, RTE_LOG_EMERG); > i40e_logtype_driver = rte_log_register("pmd.i40e.driver"); > if (i40e_logtype_driver >= 0) > - rte_log_set_level(i40e_logtype_driver, RTE_LOG_NOTICE); > + rte_log_set_level(i40e_logtype_driver, RTE_LOG_EMERG); > } > -- > 2.11.0 >