From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCD6EA10DA for ; Fri, 2 Aug 2019 22:57:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6A2291C2E7; Fri, 2 Aug 2019 22:57:05 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 53A2F1C2B6; Fri, 2 Aug 2019 22:57:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EBB5521F15; Fri, 2 Aug 2019 16:57:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Aug 2019 16:57:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=gjGs2deHk/ao3Eq65N/uaWSIdRTQW/9pYe/atfY/kTo=; b=HyqeI3lzxDpB QRZ/3CtuxIXEa/suoQ4bpLEMyK+o8AeZiylwb63G+3sUtINRUQJ/i7m+c31ZKCzY M4rg+T/QSYyZHve8PA+4y5uBKLs4bZzzjdPAbwBG5mrO3rHy/kAYpNe+wmYdYukE KhCAPs1jM8VebqqpiomrA3NiTS+JErg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=gjGs2deHk/ao3Eq65N/uaWSIdRTQW/9pYe/atfY/k To=; b=cvMnwwayu7nZwO/23HM7OTcR9NvC4L+8RE630Dc6UMIkQB/J/IX5cLW8o ep/+0s6j3bbLp0Si46UwSOECHdUAuAehbHPuLaijShBWKz00onLFq4Pgh0tgtLvd tPo2h0GstiXp36tUjZwxCdXtEAgPrX77+KyFF7LRMJ0TOn7Ypm3svLIaax/mf/q2 VuLnOW/Q6XqKzgPLoGQ7EVjWBXhYsyS05hjg/LwkBSzhuv2L6luxWDeg3J6x2eYu paDoQB7x/lbfvDZe9lxoCBeRyz5M9zbcS9PrcLwdbxVE7v9nckrQF97kxu1c1gXd gnuXJbqtODyEY72vlPlcPYnqnUo1A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleelgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DA09E8005C; Fri, 2 Aug 2019 16:57:02 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: stable@dpdk.org, dev@dpdk.org, aconole@redhat.com, msantana@redhat.com Date: Fri, 02 Aug 2019 22:57:01 +0200 Message-ID: <2288744.0SrN437FYt@xps> In-Reply-To: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/08/2019 14:27, David Marchand: > The memory tests currently check that, for normal mode (not legacy mode), > there is no memory left behind when exiting. I think this is the real bug: we are checking a behaviour that we cannot achieve currently. > The problem is that if a ethdev port is allocated when scanning pci > devices (even if the driver probe fails like when you have a virtio > management interface attached to the kernel), on exit, dpdk won't free > the associated memory since ethdev never frees the ethdev memzone. As you said in this thread, we could think about how to free it properly in a future release. For 19.08, I would suggest to disable the test with a comment explaining the reason. > Workaround this by disabling pci scan. If you choose the --no-pci workaround, please add a comment about the reason.