From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id BBF4A532E for ; Fri, 15 Jul 2016 17:08:23 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id o80so34097389wme.1 for ; Fri, 15 Jul 2016 08:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fv4tgczjgNEOIOsNApGMVMWEaxhhTw3oji28MFhS0v8=; b=RJo9Bh9D6aKWwA/dFmjIrx7VcChIlI94aUfnoQ/ZZPLy0YOyTlgu4ZTz2B8r8/ca1a 2JkRw7l4ygY7MmiuJwJsOnd89qXFJ/Ogxq8PDrtNmYisl6D5O+Q8A+55hVsM26RkE6sa EsB3JqcxQu0hOEH2+iI8WPSVLQFVyhddID2IwkokE+qFg4yelOISY0ACvZR8YRpf8Y7i flLSz7TGZZr4ubgeIyIv1GlblQn/XyWaXvS3Oti+WYkQLmVVn6AjTVUhQMRUrLYfgqE0 IigxYcjJ5pl/63pHYN6TO747p6HgjReHoUZqKOdWiwMPNsjfsGbugOjyQ4h5zpKAfsnT 0dPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Fv4tgczjgNEOIOsNApGMVMWEaxhhTw3oji28MFhS0v8=; b=MXSDhdyuvpI6E5itDtkpXEvcicZ9+niNJqTsZU1LCxmxavuwnQUHXCy/k0SYoxNyhS BNFqw4XCHRneqhEAp3dK9wkNY6+1SdP1Qrofcus7Q9tyOnrnWNb/uCRyjYYT2ASmxLfO 3bONf3RDSaq12Sq35YAOtrhkW5vH57iOWhquczwKiwXo2WfWZGhKa2MywpdvFZV8Xy/h kztB2J6Pv/Qh0zZgqS/27Q1K/NqRgBFdGzaGXbUgxWnIpEjhINBuxl2TcbmYPUmFbpuk 15tcHCxOZQ+qufQplHUQJd7Diz0jtAmEAFnIl73Smc7K4nNc6iJgFZKsU9HgspUU/D7u /mKQ== X-Gm-Message-State: ALyK8tKcnVRR1MA4clitLeaA6XZW2rko9QaGvFP0QvyR5pJX7MopQNeCxUJ/4IWyJBXKcPDP X-Received: by 10.194.140.98 with SMTP id rf2mr1360938wjb.146.1468595303476; Fri, 15 Jul 2016 08:08:23 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id kr1sm1189826wjc.46.2016.07.15.08.08.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jul 2016 08:08:22 -0700 (PDT) From: Thomas Monjalon To: damarion@cisco.com Cc: Jan Viktorin , dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , David Marchand Date: Fri, 15 Jul 2016 17:08:21 +0200 Message-ID: <2290419.B64Si7jFuQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3850930.xJZUcGIqBK@xps13> References: <20160714132729.27024-1-damarion@cisco.com> <20160714200336.119bcfce@jvn> <3850930.xJZUcGIqBK@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] spinlock: Move constructor function out of header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 15:08:23 -0000 2016-07-15 16:37, Thomas Monjalon: > I will apply it with trivial changes suggested by Jan and > the small needed changes that I describe below: > > 2016-07-14 20:03, Jan Viktorin: > > On Thu, 14 Jul 2016 15:27:29 +0200 > > damarion@cisco.com wrote: > > > --- /dev/null > > > +++ b/lib/librte_eal/common/arch/x86/rte_spinlock.c > [...] > > > +uint8_t rte_rtm_supported; /* cache the flag to avoid the overhead > > > + of the rte_cpu_get_flag_enabled function */ > > This variable must be exported in the .map file. > > > > --- a/lib/librte_eal/linuxapp/eal/Makefile > > > +++ b/lib/librte_eal/linuxapp/eal/Makefile > > > @@ -106,6 +106,7 @@ SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_keepalive.c > > > > > > # from arch dir > > > SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_cpuflags.c > > > +SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c > > > > This is not good, you provide rte_spinlock.c only for x86. Building > > for any other arch would fail to find this file. > > This change do the trick: > > -SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += rte_spinlock.c > +SRCS-$(CONFIG_RTE_ARCH_X86) += rte_spinlock.c > > (Note that CONFIG_RTE_EXEC_ENV_LINUXAPP check is not needed inside linuxapp EAL) > > > Moreover, the bsdapp/eal/Makefile should reflect this situation as > > well. > > Yes Applied with above changes, thanks