From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, techboard@dpdk.org, Min Hu <humin29@huawei.com>
Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats
Date: Tue, 13 Oct 2020 11:05:07 +0200 [thread overview]
Message-ID: <2290585.EWI7AWl3IT@thomas> (raw)
In-Reply-To: <fc5dd269-e336-18d5-cafd-d22f9e30e6a4@oktetlabs.ru>
13/10/2020 10:31, Andrew Rybchenko:
> On 10/13/20 12:53 AM, Thomas Monjalon wrote:
> > 12/10/2020 18:46, Ferruh Yigit:
> >> Queue stats are stored in 'struct rte_eth_stats' as array and array size
> >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag.
> >>
> >> As a result of technical board discussion, decided to remove the queue
> >> statistics from 'struct rte_eth_stats' in the long term.
> >>
> >> Instead PMDs should represent the queue statistics via xstats, this
> >> gives more flexibility on the number of the queues supported.
> >
> > Yes
>
> I like Stephen's idea to have dedicated API to get stats per
> queue. Of course it is doable via getting xstats by IDs,
> but IMHO it is over-complicated. From the other hand
> it sounds like a duplication to have it in xstats and
> dedicated API (basically the same as we have for basic
> stats and xstats).
Please read my proposal to have fixed ids for common stats
and fixed id ranges for stats per queue:
https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf
(slide 11)
next prev parent reply other threads:[~2020-10-13 9:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 16:46 Ferruh Yigit
2020-10-12 16:46 ` [dpdk-dev] [RFC 2/2] doc: announce queue stats moving " Ferruh Yigit
2020-10-12 16:55 ` [dpdk-dev] [dpdk-techboard] " Stephen Hemminger
2020-10-12 21:53 ` [dpdk-dev] [RFC 1/2] ethdev: move queue stats " Thomas Monjalon
2020-10-13 8:31 ` Andrew Rybchenko
2020-10-13 9:05 ` Thomas Monjalon [this message]
2020-10-13 9:16 ` Andrew Rybchenko
2020-10-13 22:41 ` Ferruh Yigit
2020-10-13 15:04 ` Stephen Hemminger
2020-10-13 22:53 ` Ferruh Yigit
2020-10-14 2:26 ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Ferruh Yigit
2020-10-14 2:26 ` [dpdk-dev] [RFC v2 2/2] doc: announce queue stats moving to xstats Ferruh Yigit
2020-10-14 8:43 ` Kinsella, Ray
2020-10-16 14:34 ` Thomas Monjalon
2020-10-16 14:36 ` Bruce Richardson
2020-10-16 14:37 ` Jerin Jacob
2020-10-16 15:07 ` Stephen Hemminger
2020-10-16 17:48 ` Ajit Khaparde
2020-10-14 9:35 ` Igor Ryzhov
2020-10-14 9:45 ` Thomas Monjalon
2020-10-15 7:55 ` Igor Ryzhov
2020-10-15 8:03 ` Thomas Monjalon
2020-10-15 17:39 ` Igor Ryzhov
2020-10-15 17:45 ` Thomas Monjalon
2020-10-14 8:40 ` [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Wang, Haiyue
2020-10-14 8:46 ` Wang, Xiao W
2020-10-16 12:16 ` Ferruh Yigit
2020-10-16 14:32 ` Thomas Monjalon
2020-10-16 21:38 ` Ferruh Yigit
2020-10-19 3:03 ` Min Hu (Connor)
2020-10-18 12:09 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2290585.EWI7AWl3IT@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).