From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85FC3A04B6; Tue, 13 Oct 2020 11:05:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F2BA91DA76; Tue, 13 Oct 2020 11:05:13 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8BB2B1C1B8; Tue, 13 Oct 2020 11:05:11 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 208F55C01BC; Tue, 13 Oct 2020 05:05:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 13 Oct 2020 05:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= b8X/MoDwB/Cbdxn+EAAglPmJJNR2de9SwGvxSXbZ93Y=; b=oEOGfICTpQMy9San 2JVEfwJ0dZ06upAFnNwKJ50den2qd/k9U6MPSnaN+gUdOY8xYDy+g4zDd82rs1Jz me7By95jB6fXXH6vIBdccipGF1JheiixsU674AvEaC0e7dRHqs8a4PuMR6nc1EEF of6F2f3IhZYcirVzTitZFVgmaa80kYyLwfyROlr6QZziiFMfpu2nY+/mXH3XAZPG AbUGTl0nNwBfgRSAOXwh6+BS1d57FVn6QhCRrHKYnVagZQ3XuAIhhnInVrr108je QIjZ0DFG9MHIuLqZdwYcQ1nFanWK9Je7T5f2hfoXoH23QGnGy9pjPpf9JgYo0umw J1dAdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=b8X/MoDwB/Cbdxn+EAAglPmJJNR2de9SwGvxSXbZ9 3Y=; b=hzNHx9Lxuy0eU1Otf9j8OVdutrBccWei4FIOnCIDjLOYrehv2KgNRkCeE rRjyn2SS23wDyC7pp6SuyROZ2CLl/QIkj5mavNLc55PyrQyaSlfrWVCJ1GvDyOqZ l8w80Wos4fm9GK8+Yutv40J5Skycz5GCfbH7A6J4HnCZOmUuGiQlkJV0jaBksEY0 AfZ+Of8mL9epnjlbmZRFrk4bS8zTDXf5IXyW/Vp298FJDu5Aq1kb5UPyUz3s6ZLD OGvCFNMp96jG+HsGztmUYxxWocuM1Q9eVhW66BVRKFJ7nDcvj6fqRZfFGP6CI0cO f30tU8MMukdMQepBKBUxoNgXXHNhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheelgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7FD44306467D; Tue, 13 Oct 2020 05:05:08 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Andrew Rybchenko , Stephen Hemminger Cc: dev@dpdk.org, techboard@dpdk.org, Min Hu Date: Tue, 13 Oct 2020 11:05:07 +0200 Message-ID: <2290585.EWI7AWl3IT@thomas> In-Reply-To: References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <3382071.xncihUvvZe@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/10/2020 10:31, Andrew Rybchenko: > On 10/13/20 12:53 AM, Thomas Monjalon wrote: > > 12/10/2020 18:46, Ferruh Yigit: > >> Queue stats are stored in 'struct rte_eth_stats' as array and array size > >> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > >> > >> As a result of technical board discussion, decided to remove the queue > >> statistics from 'struct rte_eth_stats' in the long term. > >> > >> Instead PMDs should represent the queue statistics via xstats, this > >> gives more flexibility on the number of the queues supported. > > > > Yes > > I like Stephen's idea to have dedicated API to get stats per > queue. Of course it is doable via getting xstats by IDs, > but IMHO it is over-complicated. From the other hand > it sounds like a duplication to have it in xstats and > dedicated API (basically the same as we have for basic > stats and xstats). Please read my proposal to have fixed ids for common stats and fixed id ranges for stats per queue: https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf (slide 11)