From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1C462AAF5
 for <dev@dpdk.org>; Mon,  2 Apr 2018 17:45:34 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8E77920DCE;
 Mon,  2 Apr 2018 11:45:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 02 Apr 2018 11:45:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Deu8kzviiShUBljaPLPS1MiS8I
 KckcGvPJwe5eodk8A=; b=ksHXyAQxxAvmReGKRBL1I3YrvMhGAWJHa4JoVTaxmA
 bDwk71dD3s1+jnNeCmCKcncc470Gdd+58siwnEFZbIpZy+f31lEj7l3RBvyvMKEn
 YN6s4rXplwG5R9ZSbsgKCekx5bSldEAUzDaGjMFQkupzq/vEFP7q3OFXcfsRiA1M
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Deu8kz
 viiShUBljaPLPS1MiS8IKckcGvPJwe5eodk8A=; b=krCc2Lt45QrcMoy/BQhRIq
 uK9i4+dKrvQCxHM4n5YzWgemvx09Lnf2DynVOCAJGVqrJ8Vk6Rov8SGMVPdXSBi0
 KCerp8wlaliLA1tI8JYb2geHyR/4j2MV5E7EJmB+/0pEQ8FN+dAMEiITYY1xedOd
 CysACNdWiSzRrTe/6LzzH2FdOQ+YVnzTdZWuw7rsB5RBrlUdkDpLlagrBSd5sX1N
 hZJP6NtpkebnNWpXkk0C0mkn85CvaZ2E1L0dF3vBsKEQr6KIq0RLsqRIGb3q8qDl
 J6sEntcWFjQog/DL5rV7AmCxHbW/M+9VvU7/CBcjxTUbjsaSREL4Dlfc8ihFChTA
 ==
X-ME-Sender: <xms:HVDCWsFlv62kx9dQL-cD0fytsVl8l7ZXJ_-ermhftEbvQMAA04mOXg>
Received: from xps.localnet (84.19.136.77.rev.sfr.net [77.136.19.84])
 by mail.messagingengine.com (Postfix) with ESMTPA id A5E44E443C;
 Mon,  2 Apr 2018 11:44:18 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ajit Khaparde <ajit.khaparde@broadcom.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Shijith Thotton <shijith.thotton@cavium.com>,
 Santosh Shukla <santosh.shukla@caviumnetworks.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 John Daley <johndale@cisco.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Yongseok Koh <yskoh@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Tomasz Duszynski <tdu@semihalf.com>, Jianbo Liu <jianbo.liu@arm.com>,
 Alejandro Lucero <alejandro.lucero@netronome.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Harish Patil <harish.patil@cavium.com>,
 Rasesh Mody <rasesh.mody@cavium.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Shrikrishna Khare <skhare@vmware.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, "Legacy,
 Allain (Wind River)" <allain.legacy@windriver.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, Gaetan Rivet <gaetan.rivet@6wind.com>,
 Olivier Matz <olivier.matz@6wind.com>
Date: Mon, 02 Apr 2018 17:44:10 +0200
Message-ID: <2290922.gxAzXUSjGS@xps>
In-Reply-To: <039ED4275CED7440929022BC67E7061153177096@SHSMSX103.ccr.corp.intel.com>
References: <2759953.P7QpFFSjiU@xps>
 <039ED4275CED7440929022BC67E7061153177096@SHSMSX103.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] Survey for final decision about per-port offload API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2018 15:45:34 -0000

01/04/2018 03:51, Zhang, Qi Z:
> > There are some discussions about a specific part of the offload API:
> > 	"To enable per-port offload, the offload should be set on both
> > 	device configuration and queue setup."
> > 
> > It means the application must repeat the port offload flags in
> > rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads, when calling
> > respectively rte_eth_dev_configure() and rte_eth_[rt]x_queue_setup for each
> > queue.
> > 
> > The PMD must check if there is mismatch, i.e. a port offload not repeated in
> > queue setup.
> > There is a proposal to do this check at ethdev level:
> > 	http://dpdk.org/ml/archives/dev/2018-March/094023.html
> > 
> > It was also proposed to relax the API and allow "forgetting" port offloads in
> > queue offloads:
> > 	http://dpdk.org/ml/archives/dev/2018-March/092978.html
> > 
> > It would mean the offloads applied to a queue result of OR operation:
> > 	rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads
> > 
> > 1/ Do you agree with above API change?
> > 
> > 
> > If we agree with this change, we need to update the documentation and
> > remove the checks in PMDs.
> 
> Do you mean we will move offload check from PMD to ethdev, 
> or just remove specific check in each PMD
> or it is not in the scope of this vote?

By "remove the checks", I mean removing the checks in each PMD
for the port offloads repeated in queue offloads.