From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17FB858CB
 for <dev@dpdk.org>; Sun,  9 Jul 2017 15:26:02 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id AA4DB20764;
 Sun,  9 Jul 2017 09:26:01 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Sun, 09 Jul 2017 09:26:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=G8qWvWIKgv7B+xg
 POlqjyphKfJ3xKpZjFDTCq4WHVcA=; b=lDhYNVBX1ApjUOFHD1ftM/KKETDTeeo
 rcvTq5SKPcQUtOGHU3CwuppC43YaMjwvwIscBq9vTQduwiJY2Cxo+avvus1/07Y0
 +zA0e5K76x10NB6HMZuHS44BVitPj/C8oVrxkHBnWP30E5Tu1DXQN/5vC14r+jko
 9g8PyQiujNdk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=G8qWvWIKgv7B+xgPOlqjyphKfJ3xKpZjFDTCq4WHVcA=; b=TyV7qFaQ
 we41FNOBPqDYBFT0mCth+d89aZxgx0wm1INK06OBAa1RIZ40vVuBb95Z9zWkV1Po
 0kkWovy5Wa8MXLmD8WoHa7iR1j1Bd514fVUO3MB+6bQyH4LPTUzti8+/Tt1i+sro
 3G9VUJcr6pGUdvwORXX7MMExo3VGvkaYK8ppMOHSXP/KVHHw5Oi8CScrro/Cnd/j
 USsqMOfyDFg+Uq2WnZ+IaUUOQJaEosWGVeUEUVmLoPCUrUgNwVnER4TJ0aLuMlo9
 Rc41QCxeDJsYcsqc9yFzUc+ulO45QiWgiomxRW9t9j2xv9qU5uLJlqJ05dWgqwhD
 P97wWyclg1QObA==
X-ME-Sender: <xms:6S5iWaN8VcBU8J3COEZDHoBJT3W3CKMyB4y6dtaMtc7uSVysjsHIog>
X-Sasl-enc: 9fN+o9VNzMh15S4h8T5wrw3sc8xbkgdvA5aA0ZVVp7Ta 1499606761
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 643E324251;
 Sun,  9 Jul 2017 09:26:01 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org
Date: Sun, 09 Jul 2017 15:26:00 +0200
Message-ID: <2291044.izmqMtvmdQ@xps>
In-Reply-To: <CALe+Z02_taVy7kyeWax_Yj3VXLAo1ooq8nP7TT8Tb64iPMLceQ@mail.gmail.com>
References: <20170709094416.15045-1-jblunck@infradead.org>
 <1582621.mDe9fsxt3G@xps>
 <CALe+Z02_taVy7kyeWax_Yj3VXLAo1ooq8nP7TT8Tb64iPMLceQ@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: fix build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Jul 2017 13:26:02 -0000

09/07/2017 12:43, Jan Blunck:
> On Sun, Jul 9, 2017 at 6:38 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> > 09/07/2017 11:44, Jan Blunck:
> >> Fixes 4c07e0552f0a ("crypto/scheduler: add multicore scheduling mode")
> >>
> >> drivers/crypto/scheduler/scheduler_multicore.c: In function 'scheduler_stop':
> >> drivers/crypto/scheduler/scheduler_multicore.c:286:2: error: 'for' loop
> >>  initial declarations are only allowed in C99 or C11 mode
> >>   for (uint16_t i = 0; i < sched_ctx->nb_wc; i++)
> >>   ^
> >
> > I wonder why I have not spotted it.
> > What is your compiler? which version?
> 
> This is with Debian Jessie:
> 
> gcc version 4.9.2 (Debian 4.9.2-10)

OK, so I could update the title to "fix build with old gcc" ?

And add in the log that it has been seen with gcc 4.9.2.

Do you agree?

PS: I am testing with gcc 7.1.