DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Question for queue_start
@ 2018-03-22 12:20 Zhang, Qi Z
  2018-03-22 12:27 ` Ananyev, Konstantin
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Qi Z @ 2018-03-22 12:20 UTC (permalink / raw)
  To: dev; +Cc: Ananyev, Konstantin, thomas

Hi:
         In rte_eth_dev_rx|tx_queue_start, dev_started is not checked

         Which mean we can call
         Rte_eth_rx_queue_setup
         Rte_eth_rx_qeueu_start

         And what we expected is the queue is started while device is still stopped, does this make sense?
         Should it return fail when device is not started?

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Question for queue_start
  2018-03-22 12:20 [dpdk-dev] Question for queue_start Zhang, Qi Z
@ 2018-03-22 12:27 ` Ananyev, Konstantin
  2018-03-22 12:59   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Ananyev, Konstantin @ 2018-03-22 12:27 UTC (permalink / raw)
  To: Zhang, Qi Z, dev; +Cc: thomas

Hi Qi, 


>Hi:
>       In rte_eth_dev_rx|tx_queue_start, dev_started is not checked
>         
>      Which mean we can call  
>         Rte_eth_rx_queue_setup
>         Rte_eth_rx_qeueu_start         
>
>         And what we expected is the queue is started while device is still stopped, does this make sense?
>         Should it return fail when device is not started?

Good point, I think we should.
Konstantin

>
>Thanks
>Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [dpdk-dev] Question for queue_start
  2018-03-22 12:27 ` Ananyev, Konstantin
@ 2018-03-22 12:59   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-03-22 12:59 UTC (permalink / raw)
  To: Ananyev, Konstantin; +Cc: Zhang, Qi Z, dev

22/03/2018 13:27, Ananyev, Konstantin:
> Hi Qi, 
> 
> 
> >Hi:
> >       In rte_eth_dev_rx|tx_queue_start, dev_started is not checked
> >         
> >      Which mean we can call  
> >         Rte_eth_rx_queue_setup
> >         Rte_eth_rx_qeueu_start         
> >
> >         And what we expected is the queue is started while device is still stopped, does this make sense?
> >         Should it return fail when device is not started?
> 
> Good point, I think we should.

Yes, I think there was no intent to start a queue of a stopped device.

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-22 12:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22 12:20 [dpdk-dev] Question for queue_start Zhang, Qi Z
2018-03-22 12:27 ` Ananyev, Konstantin
2018-03-22 12:59   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).