From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id CDD30567E
 for <dev@dpdk.org>; Wed,  6 Jul 2016 11:46:24 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id f126so166837076wma.1
 for <dev@dpdk.org>; Wed, 06 Jul 2016 02:46:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=WEpmThXoegFPpmGOSAx3WK79ZqIwGJRMr+jctqfV+xk=;
 b=cTtHHQ0Me/9XCu5E44ilPgU7ORUB+SEj8+RL+xTlKEn4eLMbO/zUy2n4AmgelE7PO1
 XRDijAl4caKvXqbr5uLtOcK1xCzG34RP4gPcP2eMqKLVK8CqHAW7DDdoFqXWWJrJIK99
 LCxnfPlJ7XTTq7H/CwB6WvlklNv6dYkU8ZZKhMT3yN6Ae7bNaCAizrwgsW287e/gWhfQ
 wumeMT+EIYyXyM+AeP9gt4kjqDMJSovkmDlw0G82URatSojUrZN3bOZAhIwp/8o9LFQI
 DjEflzIDTT6qk5y6jmqqHXuwIQuoBLTS7GMM819QER0MTHqK6Iegl6HU7rVLaJsOGqBw
 Gw+A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=WEpmThXoegFPpmGOSAx3WK79ZqIwGJRMr+jctqfV+xk=;
 b=ZAGO0qTmSC84SWhQPX9WcN3px2ZZ42U/FZaAi5brgOtItR9HDqBKAWIKhpgaGRVS8o
 0zXWvLbbDD31sdk4e+cV6rjjhmK/ecmV0j7uGV83hAVPBJR54pLkq0cXkbhiGMyDDsNm
 D+KYNrrN0xPGSfppwjwUNIWYqa/4Pms8bRpUeMSPEwApsEhbLc3rPCShcLG4e4gEtBfa
 WLY2AFCzNgQk/TKxwz3XX7LvlveaAXIGKZQ/Pt2M854AFJh/T1MBxX01jz0If8vc3UiP
 9UJI+URB/NUWAES4aA3WUIzAWn62G6Bh2TItqb0ziaoZY2gZClC1DBTVKGAGlQEh6/pg
 gqzw==
X-Gm-Message-State: ALyK8tI92Dvjr8bedwQ/h5CljAPB0l2WTNeMCiYX9eKsoBjaUbW5MfHvez4VjLgrbodRMSlq
X-Received: by 10.194.104.40 with SMTP id gb8mr21619555wjb.146.1467798384570; 
 Wed, 06 Jul 2016 02:46:24 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id t67sm6962370wma.1.2016.07.06.02.46.23
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Jul 2016 02:46:24 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com
Date: Wed, 06 Jul 2016 11:46:23 +0200
Message-ID: <22935387.s4eUy1AmSX@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <20160706092524.GC17404@bricha3-MOBL3>
References: <1467729650-925-1-git-send-email-bruce.richardson@intel.com>
 <6142444.k3HLHFvhXo@xps13> <20160706092524.GC17404@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] scripts: add check for net driver names
	without net prefix
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jul 2016 09:46:25 -0000

2016-07-06 10:25, Bruce Richardson:
> On Wed, Jul 06, 2016 at 11:10:48AM +0200, Thomas Monjalon wrote:
> > 2016-07-05 15:40, Bruce Richardson:
> > > +# check headline label for net/ prefix if needed
> > > +bad=$(echo "$headlines" | grep -E --color=always \
> > > +	-e "^($(ls drivers/net | grep -v Makefile | tr '\n' '|')):" \
> > > +	| sed 's,^,\t,')
> > > +[ -z "$bad" ] || printf "Headline missing 'net/' prefix:\n$bad\n"
> > 
> > This check is definitely a good idea.
> > We need the same thing for crypto.
> > Few nits:
> > - -E is not needed for this regex
> > - "/base:" cases are not handled because of the colon at the end
> > of the regex.
> 
> Good point. Easy enough to fix, I suspect.
> 
> > - patches touching several drivers are not handled. Examples:
> >   "mlx:" -> "net/mlx:"
> >   "drivers/net:" -> "net:"
> > 
> Yes, however, those are in the minority of cases, and we can always add
> special case extra regex's for those - hardcoded like the other regex's in the
> file. I did the pulling directory list so we don't have to update the checks
> every time a new driver was added.

Another issue: I suspect you will have false positives with librte_ring and
librte_vhost.

> > By the way, I am looking at an idea, that Nelio sent me, based on
> > modified files. It can complete this check.
> 
> Great. I'll look forward to seeing that. If it works out well, by all means
> drop this patch. If it's not coming any time soon though, I can do a V2 of
> this patch, but I won't bother right now in the expectation that a better
> solution is coming.

My concern is that the file-based solution will handle only the patches where
every changes are in drivers/ (not config/ or anything else).
I'm thinking how to merge both solutions.

I'm also concerned by the time passed developing these checks ;)