From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 11E11A046B for ; Mon, 24 Jun 2019 18:25:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 65CB61BB4F; Mon, 24 Jun 2019 18:25:55 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6E61D1B9E0 for ; Mon, 24 Jun 2019 18:25:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B022D223DE; Mon, 24 Jun 2019 12:25:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 24 Jun 2019 12:25:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=nEHnb25D4NZ5qDTFf3YGODZVPKpU+k8xP9HHLIGtoc4=; b=Qg3BHwshbq2/ ZtCTzLBkO/6s5jQ8hTormsnoZr6FmMygq5Y0nJlttSB9HZQ1BA2Lefwz6uN4l+d1 gG/MVQROSSWOBYxENIoscLvwfbnQG01zuDn3C5yegsdkyMOl4M2Q+esmyfatYuAY m3qd81qucCij9Y/fSMG5E72RDKb7eS8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nEHnb25D4NZ5qDTFf3YGODZVPKpU+k8xP9HHLIGto c4=; b=AgGTJdUwnx8FCqxBDbMs2ad+T9Sp1hbAM3gfnbVZbgyUmm27nFGuYIH5j Jc0klbl2W5vKs6xSuFSW1b5G46NIu007xLhLCBnyeslJ69tbybA3guc8pzRlgw0Y 27AXZ0NHfk8qNtda7J227bIaE0U9i3moxfNiAGK+da/5yBcyprKY4yu3bP+Odc3+ Qh0qRvky1Py1Z3uV/8SCHzCgZ44l4prRB7qiY5FBAMbUM2cAd1shx2ObYfewualy 0NDlyW8xR6TBFiYAbARWcVtO5wxohZn7zpZnOhFIYfrjV6nKFtU39LDXugSRfPAk cMNr6Pizc+4RyxPecqrl4t92E33Mg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddvgddutdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 295E5380087; Mon, 24 Jun 2019 12:25:51 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli , "Phil Yang (Arm Technology China)" Cc: "jerinj@marvell.com" , "dev@dpdk.org" , "hemant.agrawal@nxp.com" , "Gavin Hu (Arm Technology China)" , nd , "gage.eads@intel.com" Date: Mon, 24 Jun 2019 18:25:49 +0200 Message-ID: <22963143.DP9djbVQ2r@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/3] eal/arm64: add 128-bit atomic compare exchange X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/06/2019 18:12, Honnappa Nagarahalli: > > > > + } else { > > > > + rte_panic("Invalid memory order\n"); > > > > > > > > > rte_panic should be removed from library. In this case, I think, > > > invalid mo can go for strongest barrier. > > It is added here to capture programming errors. > Memory order can be passed during compilation or during run time. > 'rte_panic' supports both of these. > Adding code with strongest memory order will mask the programming error. An error must return a specific code from the function. rte_panic is really forbidden in libraries. We are in the process of removing all of them.