From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 129E158F8 for ; Fri, 16 May 2014 16:22:54 +0200 (CEST) Received: by mail-wi0-f171.google.com with SMTP id hm4so1042886wib.10 for ; Fri, 16 May 2014 07:23:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=jYl9YsCbMCGYAD9znLSaPavmRpjgtScbeeXflckDIwk=; b=YxzhmPt7edhtLM5fm2S4fV9ihLO/pdWqzeZzNWXd0B5Q5WFlXI8PYr+WvSshtBs5AI lq5o4BfMQHqRphydPkT4wqv/bfF3SOdWaMjWNgb2AYgq2qImxqMP/vl3B/3oaFaCspaz x59eZCrEiBzULNKewS4DZlS+ZIjc6A8n53C4GGxRJIvGy1iNBz0Iqq9dMLAGkR9wLCkN Vj7JAJmbS323Ou7KxoE76ljq817CgUCotvitPE/v845eOadII6H5cxevtf+gJkOsSh7U ulCh1PoXYP9Q1ueFpzIqMw9HWNSTAHOwz28a/pxW34pj0ARvPU0jPcFICzpQSPi0MQhK 79MA== X-Gm-Message-State: ALoCoQlhiWIXVxVNNAqDBs8x/IxS6uaMIuQ2QOM5KB6iDLzhPJnizLEzLvP8NbusNuybBvkaQv9h X-Received: by 10.194.62.234 with SMTP id b10mr14426754wjs.48.1400250182985; Fri, 16 May 2014 07:23:02 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id dk10sm1758524wib.1.2014.05.16.07.23.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 May 2014 07:23:01 -0700 (PDT) From: Thomas Monjalon To: Cyril Chemparathy Date: Fri, 16 May 2014 16:22:58 +0200 Message-ID: <2296399.R20Tya40om@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1396546216-29200-1-git-send-email-cchemparathy@tilera.com> References: <1396546216-29200-1-git-send-email-cchemparathy@tilera.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/6] Extensions to test-pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2014 14:22:55 -0000 Hi Cyril, 2014-04-03 10:30, Cyril Chemparathy: > This patch series contains a few minor extensions to test-pmd. These > changes have been added primarily for convenience while testing out various > scenarios with DPDK. > > Cyril Chemparathy (6): > test-pmd: add support for single port loopback topology > test-pmd: add support for auto-start when interactive > test-pmd: allow command line selection of forwarding mode > test-pmd: allow txpkts to be setup via command line > test-pmd: add mac swap forwarding mode > test-pmd: add flowgen forwarding engine Thanks for these new features. This is not the first time a new engine is added by copy/pasting the most part of an existing engine. For instance, the "mac-retry" engine was added by Intel as a copy/paste of the original "mac" one. This is acceptable but not the perfect way to implement engines. To address this issue, a new engine function could be introduced to setup some parameters to be used by "packet_fwd" function. This way, similar engines could be removed. Acked-by: Thomas Monjalon Applied for version 1.7.0. -- Thomas