From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8391041B9E; Wed, 1 Feb 2023 12:11:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7014A42B8E; Wed, 1 Feb 2023 12:11:29 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CD4D04021F for ; Wed, 1 Feb 2023 12:11:27 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7539D5C00A8; Wed, 1 Feb 2023 06:11:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 01 Feb 2023 06:11:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675249887; x= 1675336287; bh=ytCEqRnmzLfLCXeijmUpnERaWbQ+iMG0TG+U3vMAFQ0=; b=J r4mxP9UgtDlu9HLNBsWCa6oJh86k/QNqhV0msR7dYIHk1ura1WpjdINXMNFTZ+DP JH7BkkM8i8J118LWaKBbGD9BtN4rMZw+VSHz/nVAQrJe9zJMnS2AzBZb8wntp/s0 hknacI2d7szJGkxxU+VrSEiwN2HL7e+x1fXa+y8mjlc3tAY+Khe+Ih5AppBg+Gxk Fu91M9e1FScYb2IQiA/AtsLgflnsZzp42HUlh4LhpTt9mgNJXZ+mAg/5FN/zPnkY vrvrAyQEqyFB5SpSbzqcgDEXYLn7SCtLPtZtEmTMEFH1MV5sUuNnFq0bxit+CxD4 jRXVnRD7CZapGzmclCB6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675249887; x= 1675336287; bh=ytCEqRnmzLfLCXeijmUpnERaWbQ+iMG0TG+U3vMAFQ0=; b=I EqS5VGhYSXLoQKNzBNVGJkOu6+7eRdPLMomuF7rfpOamGxhnLDEbMTp+9YYXTY4s mL+R/+1fc0R5X8cXR65TddiNt/ki804UHHZWAzC3EbCfFfSATnu1qsLmxK2n+RfK 7YiNoUjwbX4D15pn7IeR0BLXEF67cN4bZzATQk9uhf4vBqXQn+0XUtqWY/ZEZ4UD U8OtxyHeWuYnctMNn05gkaWI6Da9v/JdlsQY9lOACGe8DCuulAcgCKywrAKgPlmg f6WFMrL/L5XCqAucsNMtGGQVR0LduHJ4dT6fyOJgKmya3iffYqesTCB4Zq6QpWTC +O4ZhQcQYSGUeFXxLULZA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefiedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeduteeiuefhtddugfevheefffeiheffvddtjeduhfehveefhfet heefiefgteehheenucffohhmrghinhepihhnthgvlhdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Feb 2023 06:11:25 -0500 (EST) From: Thomas Monjalon To: David Marchand , "mb@smartsharesystems.com" , "ferruh.yigit@amd.com" , "Zhang, Ke1X" Cc: "dev@dpdk.org" , "Matz, Olivier" , "Zhang, Yuying" , "Xing, Beilei" Subject: Re: [PATCH v2] net/i40e: support enabling/disabling source pruning Date: Wed, 01 Feb 2023 12:11:24 +0100 Message-ID: <2296416.n0HT0TaD9V@thomas> In-Reply-To: References: <20230109022027.190627-1-ke1x.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 31/01/2023 04:28, Zhang, Ke1X: > From: David Marchand > > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang wrote: > > > > > > VRRP advertisement packets are dropped on i40e PF devices because > > when > > > a MAC address is added to a device, packets originating from that MAC > > > address are dropped. > > > > > > This patch adds a PMD specific API to enable/disable source pruning to > > > fix above issue. > > > > > > Bugzilla ID: 648 > > > > > > Signed-off-by: Ke Zhang > > > --- > > > app/test-pmd/cmdline.c | 84 > > +++++++++++++++++++++++++++++++++ > > > drivers/net/i40e/i40e_ethdev.c | 43 +++++++++++++++++ > > > drivers/net/i40e/i40e_ethdev.h | 1 + > > > drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++ > > > drivers/net/i40e/rte_pmd_i40e.h | 16 +++++++ > > > 5 files changed, 164 insertions(+) > > > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > > cb8c174020..76a574affd 100644 > > > --- a/app/test-pmd/cmdline.c > > > +++ b/app/test-pmd/cmdline.c > > > @@ -776,6 +776,9 @@ static void cmd_help_long_parsed(void > > > *parsed_result, > > > > > > "port cleanup (port_id) txq (queue_id) (free_cnt)\n" > > > " Cleanup txq mbufs for a specific Tx queue\n\n" > > > + > > > + "port config (port_id|all) src_prune (on|off)\n" > > > + " Set source prune on port_id, or all.\n\n" > > > ); > > > } > > > > > > > - This seems i40e specific, please move to drivers/net/i40e/i40e_testpmd.c. > > > > - Besides, I would prefer that something in the command name clearly states > > this is driver (here, i40e) specific. > > Like "port config XX i40e_src_prune" or maybe the other way around, start > > with a "driver i40e" prefix. > > > > Maybe others have an opinion. > > > > > > -- > > David Marchand > > Thanks for your comments, this command could be used for other Intel NIC like ice, > And It is only finished for i40e in this story: https://jira.devtools.intel.com/browse/DPDK-29564 Only Intel has access to this URL. On the principle, you should not update testpmd commands in a patch for i40e. We add testpmd commands when adding new features in ethdev. Here specifically, you are adding rte_pmd_i40e_set_src_prune() with a vague explanation: "Enable/Disable source prune on all the PF." Without more information, I cannot judge whether the feature is generic or not. So for now, this is a nack.