From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f174.google.com (mail-we0-f174.google.com [74.125.82.174]) by dpdk.org (Postfix) with ESMTP id C4E7E5424 for ; Thu, 22 Jan 2015 14:00:24 +0100 (CET) Received: by mail-we0-f174.google.com with SMTP id x3so1605587wes.5 for ; Thu, 22 Jan 2015 05:00:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=RztlxD5yXXX/1VonEyj0hVR/wuHYT7injrSFxp2qCTo=; b=F34UtytsKmo++6AL4yXDBj+OUR43SXhH26B7uiIEVLH+W6+Gd2fFmqzfDF43jeaDdg CSiCX4Rq41F0O4fOL4C9oOXHgj2/6EutIvp3lArPr+nWIn1wUnNnpsbaii2dx9k6gthJ OUkvC0xwFXBJx3lLMy4SO/Vf33/cakkfK/pCyFsHPG/1pcvUfVs0/hTmibmUoJxFkMZt ncdwoEUuU4BZYjBSvF4WlxlRvmzL/vANZ2pvZIs9RQegBrkLrfsz4mtsRcJovzEnh6Rg L/PeAUQIh8eGr8UhZ0T586ST0nWizyQ7v7HpbdCvGYp4cAVCQDm81Dk/UIZ6XlAfwuIG PyNQ== X-Gm-Message-State: ALoCoQnYXBLDyBOSD87FGTOSI721zgTZH8QgvYCLzlooDgsSxZCFjth9/FRDklytx1XtzE5/hURb X-Received: by 10.181.27.199 with SMTP id ji7mr5062101wid.76.1421931623859; Thu, 22 Jan 2015 05:00:23 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id uq1sm3897364wjc.14.2015.01.22.05.00.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 05:00:22 -0800 (PST) Date: Thu, 22 Jan 2015 05:00:22 -0800 (PST) X-Google-Original-Date: Thu, 22 Jan 2015 14:00 +0100 From: Thomas Monjalon To: "Chi, Xiaobo (NSN - CN/Hangzhou)" Message-ID: <2296434.5EpfcH711R@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.18.2-2-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20150122111732.GA4580@bricha3-MOBL3> References: <1417601518-16852-1-git-send-email-xiaobo.chi@nsn.com> <20150122111732.GA4580@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] add one option memory-only for secondary processes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 13:00:24 -0000 2015-01-22 11:17, Bruce Richardson: > On Thu, Jan 22, 2015 at 09:05:34AM +0000, Chi, Xiaobo (NSN - CN/Hangz= hou) wrote: > > Hi, Bruce, > > Since the DPDK2.0 merge window is opened now, so is it possible for= this patch to be one candidate for v2.0? > > I searched in the DPDK patchwork(http://www.dpdk.org/dev/patchwork/= project/dpdk/list/?state=3D*&q=3Dmemory-only&archive=3Dboth ), but can = not find this V2 patch. Can you please help to check why? Thanks a lot.= > >=20 > > Filters: Search =3D memory-only remove filter > > Patch=09 Date=09Submitter=09Delegate=09State > > [dpdk-dev] add one option memory-only for those secondary PRBs=0920= 14-12-02=09chixiaobo=09=09Not Applicable > > [dpdk-dev] add one option memory-only for those secondary PRBs=0920= 14-12-02=09chixiaobo=09=09Changes Requested > >=20 > > Brgs, > > Chi Xiaobo > >=20 > That's a question that Thomas is better able to answer than me, since= he is the > man with control over patchwork! :-) >=20 > Thomas, any feedback here? I have no log for this kind of problem. But I know that patchwork ignores emails with special characters. And in your commit log, there are some in "mechanism and it?=EF=BF=BD=EF= =BF=BDs upper libs". Moreover, this commit log should be wrapped. A quick look shows also that some spaces/tabs are missing. It was a v2 and there is no change log. Please submit a v3 after cleaning. I didn't review this patch and nobody gave its Acked-by. So at the moment, it's pending. I'll try to review v3 carefully. Other comments are welcome. I feel this patch can break some important = things. Which tests have you done? (it could be described in commit log) Last point: I don't like the current implementation of secondary proces= s and Ericsson wanted to discuss their own implementation: =09http://dpdk.org/ml/archives/dev/2014-December/009796.html --=20 Thomas