From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9489E460FD; Thu, 23 Jan 2025 17:02:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A76B4028A; Thu, 23 Jan 2025 17:02:48 +0100 (CET) Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) by mails.dpdk.org (Postfix) with ESMTP id C204140261 for ; Thu, 23 Jan 2025 17:02:45 +0100 (CET) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.stl.internal (Postfix) with ESMTP id D7C2D114015E; Thu, 23 Jan 2025 11:02:44 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Thu, 23 Jan 2025 11:02:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1737648164; x=1737734564; bh=g4E6CeT8Y1LPH0+XyATjayP9siNhZtsfI++g1Mga3vs=; b= nqfE2mg3kqWaJK4Cym1OXrd4iQxt1eo1sfPJ447/EgpIB5v/H476upF5sxtanyAM tVU+QW2Im1qfR00Zx755lW7dKQ+yMtKN6Mu4kctjbYiuvaMUTRW/6KS0Uhsnk4Wd yvxMKfjytDfXd9v7NgnwUSZii4dVqvhA+moEOHJjqSRB81YXLHu8nQle91xCiLQj ratNIXbe3NziOM2TnVV6I6gscjpRbhn3i8h+Xt3LpbZSuuBjm7yWRTTScO8IFdK/ avMS9WN/N+ayDJQFwZB9KodtrbAaO3kp9aR+Smk/rnRoki4y+gxoFauGsvwB7OGB sq/A+u1PANh/wejwrtPeRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1737648164; x= 1737734564; bh=g4E6CeT8Y1LPH0+XyATjayP9siNhZtsfI++g1Mga3vs=; b=o 2X8jIQnSztHJz1QMvYoRH41yVLGtMBfdPGaPgdu+ujsxy8Am1vH2e6U25Afow4/d N1TE7od+023RLa73Ww5Outxk9/Woe6I87iY7tyidVvJ26ZN8OaC0vvOOqMbPR/U6 zPusNgWI09l1pgi/Uv9FZVD3aHayL86PPLHN7upqgLwg5NqtcUryWQDQOsDgNViS P9kIniTOP5mDCHNKEOyvbfqOwhSloxm4Uw17QlgJmyPXFyCWuhTBevtUiU/wCqhA gJW76SsNdLglluYiwqYDi+uEO3QnQaQJG6Ee45ccu2l8RCkMFlF8d0L7rmwkyW+v 9djdw/qr47L6Q+RgiTzwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrudejgedgvddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdej necuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjh grlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdeg keeuveejffejgedtgeegkefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthdp nhgspghrtghpthhtohepudefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegurg hvihgurdhmrghrtghhrghnugesrhgvughhrghtrdgtohhmpdhrtghpthhtohepsghruhgt vgdrrhhitghhrghrughsohhnsehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesug hpughkrdhorhhgpdhrtghpthhtohepkhhonhhsthgrnhhtihhnrdhvrdgrnhgrnhihvghv seihrghnuggvgidrrhhupdhrtghpthhtohepughrtgeslhhinhhugidrihgsmhdrtghomh dprhgtphhtthhopeifrghthhhsrghlrgdrvhhithhhrghnrghgvgesrghrmhdrtghomhdp rhgtphhtthhopehprhgrvhgvvghnrdhshhgvthhthiesihhnthgvlhdrtghomhdprhgtph htthhopehirghnrdhsthhokhgvshesihhnthgvlhdrtghomhdprhgtphhtthhopehvlhgr ughimhhirhdrmhgvughvvggukhhinhesihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Jan 2025 11:02:42 -0500 (EST) From: Thomas Monjalon To: David Marchand , Bruce Richardson Cc: dev@dpdk.org, Konstantin Ananyev , David Christensen , Wathsala Vithanage , Praveen Shetty , Ian Stokes , Vladimir Medvedkin , Anatoly Burakov , Jingjing Wu , Rosen Xu , Robin Jarry Subject: Re: [PATCH v5 01/25] net: move intel drivers to intel subdirectory Date: Thu, 23 Jan 2025 17:02:40 +0100 Message-ID: <2297034.HovnAMPojK@thomas> In-Reply-To: References: <20241122125418.2857301-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2025 15:35, Bruce Richardson: > On Thu, Jan 23, 2025 at 03:16:40PM +0100, David Marchand wrote: > > On the check-git-log.sh update, we will have many warnings with current update. > > > > Wrong headline prefix: > > net/intel/common: add pkt reassembly fn for intel drivers > > net/intel/common: provide common Tx entry structures > > net/intel/common: add Tx mbuf ring replenish fn > > net/intel: align Tx queue struct field names > > net/intel: add prefix for driver-specific structs > > net/intel/common: merge ice and i40e Tx queue struct > > net/iavf: use common Tx queue structure > > net/ixgbe: use common Tx queue structure > > net/intel/common: pack Tx queue structure > > net/intel/common: add post-Tx buffer free function > > net/intel/common: add Tx buffer free fn for AVX-512 > > net/iavf: use common Tx free fn for AVX-512 > > net/ice: move Tx queue mbuf cleanup fn to common > > net/iavf: use common Tx queue mbuf cleanup fn > > net/ice: use vector SW ring for all vector paths > > net/intel/common: remove unneeded code > > net/intel/common: create common mbuf initializer fn > > net/intel/common: extract common Rx vector criteria > > > > Invalid patch(es) found - checked 25 patches > > > > I tried to tweak this a bit, with the following heuristic: > > * if touching only net/intel/common, accept net/intel/common: > > * if touching multiple drivers under net/intel, then accept net/intel: > > as prefix, > > * if touching some net/intel/$drv (and optionnally net/intel/common), > > accept net/$drv, > > > > diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh > > index b2da013f6c..41c290f0ca 100755 > > --- a/devtools/check-git-log.sh > > +++ b/devtools/check-git-log.sh > > @@ -79,11 +79,18 @@ bad=$(for commit in $commits ; do > > [ -z "$(echo "$files" | grep -v '^\(drivers\|doc\|config\)/')" ] || > > continue > > drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f 2,3 | sort -u) > > - # for drivers/net/intel/* use 2nd and 4th fields not 2nd and 3rd > > if [ "$drv" = "net/intel" ] ; then > > - drv=$(echo "$files" | grep '^drivers/' | cut -d "/" -f > > 2,4 | sort -u) > > + drvgrp="net/intel" > > + drv=$(echo "$files" | grep '^drivers/' | grep -v > > '^drivers/net/intel/common' | > > + cut -d "/" -f 2,4 | sort -u) > > + if [ $(echo "$drv" | wc -l) -eq 0 ] ; then > > + drv='net/intel/common:' > > + elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > + drv='net/intel:' > > + fi > > + else > > + drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > > fi > > - drvgrp=$(echo "$drv" | cut -d "/" -f 1 | uniq) > > if [ $(echo "$drvgrp" | wc -l) -gt 1 ] ; then > > echo "$headline" | grep -v '^drivers:' > > elif [ $(echo "$drv" | wc -l) -gt 1 ] ; then > > > > Which then complains on patches in this series that touch many drivers > > (but have net/intel/common: as prefix where I would suggest net/intel: > > instead). > > > > I tend to disagree with this suggestion. I think that a prefix can be valid > so long as the prefix matches at least one component in the patch. For example, > for the first patch in the set, I think net/intel/common is a better prefix > than just "net/intel". I don't massively object to your suggestion, I just > prefer patches identify the most relevant component, if possible, rather > than generalities. Saying net/intel means the same thing as net/intel/common to me. Why do we care whether the change is in common or multiple drivers? At the end it impacts multiple Intel drivers. The goal of the prefix is to quickly catch the scope of the change impact. One more argument: net/intel is shorter :)