[dpdk-dev] [PATCH] relicense various bits of the dpdk

[dpdk-dev] [PATCH] relicense various bits of the dpdk

[Neil Horman]

Received a note the other day from the Linux Foundation governance board
for DPDK indicating that several files I have copyright on need to be
relicensed to be compliant with the DPDK licensing guidelines.  I have
some concerns with some parts of the request, but am not opposed to
other parts.  So, for those pieces that we are in consensus on, I'm
proposing that we change their license from BSD 2 clause to 3 clause.
I'm also updating the files to use the SPDX licensing scheme

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>
CC: Thomas Monjalon <thomas@monjalon.net>
---
 devtools/validate-abi.sh       | 32 ++++----------------------------
 lib/librte_compat/rte_compat.h | 24 +-----------------------
 2 files changed, 5 insertions(+), 51 deletions(-)

diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
index 8caf43e83..26f3f9d0d 100755
--- a/devtools/validate-abi.sh
+++ b/devtools/validate-abi.sh
@@ -1,32 +1,8 @@
 #!/usr/bin/env bash
-#   BSD LICENSE
-#
-#   Copyright(c) 2015 Neil Horman. All rights reserved.
-#   Copyright(c) 2017 6WIND S.A.
-#   All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-#     * Redistributions of source code must retain the above copyright
-#       notice, this list of conditions and the following disclaimer.
-#     * Redistributions in binary form must reproduce the above copyright
-#       notice, this list of conditions and the following disclaimer in
-#       the documentation and/or other materials provided with the
-#       distribution.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#	SPDX-License-Identifier:	BSD-3-Clause
+#	Copyright(c) 2015 Neil Horman. All rights reserved.
+#	Copyright(c) 2017 6WIND S.A.
+#	All rights reserved
 
 set -e
 
diff --git a/lib/librte_compat/rte_compat.h b/lib/librte_compat/rte_compat.h
index 41e8032ba..2f8a0e2a6 100644
--- a/lib/librte_compat/rte_compat.h
+++ b/lib/librte_compat/rte_compat.h
@@ -1,31 +1,9 @@
 /*-
- *   BSD LICENSE
+ *   SPDX-License-Identifier: BSD-3-Clause 
  *
  *   Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
  *   All rights reserved.
  *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef _RTE_COMPAT_H_
-- 
2.14.3

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

[Hemant Agrawal]

On 12/4/2017 9:25 PM, Neil Horman wrote:
> Received a note the other day from the Linux Foundation governance board
> for DPDK indicating that several files I have copyright on need to be
> relicensed to be compliant with the DPDK licensing guidelines.  I have
> some concerns with some parts of the request, but am not opposed to
> other parts.  So, for those pieces that we are in consensus on, I'm
> proposing that we change their license from BSD 2 clause to 3 clause.
> I'm also updating the files to use the SPDX licensing scheme
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/validate-abi.sh       | 32 ++++----------------------------
>  lib/librte_compat/rte_compat.h | 24 +-----------------------
>  2 files changed, 5 insertions(+), 51 deletions(-)

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

[Thomas Monjalon]

04/12/2017 16:55, Neil Horman:
> +#	SPDX-License-Identifier:	BSD-3-Clause
> +#	Copyright(c) 2015 Neil Horman. All rights reserved.
> +#	Copyright(c) 2017 6WIND S.A.
> +#	All rights reserved
[...]
>  /*-
> - *   BSD LICENSE
> + *   SPDX-License-Identifier: BSD-3-Clause 
>   *
>   *   Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
>   *   All rights reserved.
>   *
>   */

Other SPDX headers use only one space after # or *,
and no empty line.

Also, SPDX should be on the first line (except for scripts):
	/* SPDX-License-Identifier: BSD-3-Clause

Please, let's take this opportunity to have consistent headers.
Thanks

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

[Thomas Monjalon]

05/01/2018 11:53, Thomas Monjalon:
> 04/12/2017 16:55, Neil Horman:
> > +#	SPDX-License-Identifier:	BSD-3-Clause
> > +#	Copyright(c) 2015 Neil Horman. All rights reserved.
> > +#	Copyright(c) 2017 6WIND S.A.
> > +#	All rights reserved
> [...]
> >  /*-
> > - *   BSD LICENSE
> > + *   SPDX-License-Identifier: BSD-3-Clause 
> >   *
> >   *   Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
> >   *   All rights reserved.
> >   *
> >   */
> 
> Other SPDX headers use only one space after # or *,
> and no empty line.
> 
> Also, SPDX should be on the first line (except for scripts):
> 	/* SPDX-License-Identifier: BSD-3-Clause
> 
> Please, let's take this opportunity to have consistent headers.
> Thanks

Ping.
Please could you do a v2?
Thanks

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

[Neil Horman]

On Thu, Feb 01, 2018 at 01:31:34AM +0100, Thomas Monjalon wrote:
> 05/01/2018 11:53, Thomas Monjalon:
> > 04/12/2017 16:55, Neil Horman:
> > > +#	SPDX-License-Identifier:	BSD-3-Clause
> > > +#	Copyright(c) 2015 Neil Horman. All rights reserved.
> > > +#	Copyright(c) 2017 6WIND S.A.
> > > +#	All rights reserved
> > [...]
> > >  /*-
> > > - *   BSD LICENSE
> > > + *   SPDX-License-Identifier: BSD-3-Clause 
> > >   *
> > >   *   Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
> > >   *   All rights reserved.
> > >   *
> > >   */
> > 
> > Other SPDX headers use only one space after # or *,
> > and no empty line.
> > 
> > Also, SPDX should be on the first line (except for scripts):
> > 	/* SPDX-License-Identifier: BSD-3-Clause
> > 
> > Please, let's take this opportunity to have consistent headers.
> > Thanks
> 
> Ping.
> Please could you do a v2?
> Thanks
> 
Shoot, apologies, completely lost track of this, I'll take care of it in the morning
Neil

[dpdk-dev] [PATCH v2] relicense various bits of the dpdk

[Neil Horman]

Received a note the other day from the Linux Foundation governance board
for DPDK indicating that several files I have copyright on need to be
relicensed to be compliant with the DPDK licensing guidelines.  I have
some concerns with some parts of the request, but am not opposed to
other parts.  So, for those pieces that we are in consensus on, I'm
proposing that we change their license from BSD 2 clause to 3 clause.
I'm also updating the files to use the SPDX licensing scheme

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: Hemant Agrawal <hemant.agrawal@nxp.com>
CC: Thomas Monjalon <thomas@monjalon.net>

---
Change notes
V2) Cleaned up formatting (tmonjalon)
---
 devtools/validate-abi.sh       | 32 ++++----------------------------
 lib/librte_compat/rte_compat.h | 31 +++----------------------------
 2 files changed, 7 insertions(+), 56 deletions(-)

diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
index 8caf43e83..ee64b08fa 100755
--- a/devtools/validate-abi.sh
+++ b/devtools/validate-abi.sh
@@ -1,32 +1,8 @@
 #!/usr/bin/env bash
-#   BSD LICENSE
-#
-#   Copyright(c) 2015 Neil Horman. All rights reserved.
-#   Copyright(c) 2017 6WIND S.A.
-#   All rights reserved.
-#
-#   Redistribution and use in source and binary forms, with or without
-#   modification, are permitted provided that the following conditions
-#   are met:
-#
-#     * Redistributions of source code must retain the above copyright
-#       notice, this list of conditions and the following disclaimer.
-#     * Redistributions in binary form must reproduce the above copyright
-#       notice, this list of conditions and the following disclaimer in
-#       the documentation and/or other materials provided with the
-#       distribution.
-#
-#   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-#   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-#   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-#   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-#   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-#   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-#   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-#   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-#   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-#   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-#   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+# SPDX-License-Identifier:	BSD-3-Clause
+# Copyright(c) 2015 Neil Horman. All rights reserved.
+# Copyright(c) 2017 6WIND S.A.
+# All rights reserved
 
 set -e
 
diff --git a/lib/librte_compat/rte_compat.h b/lib/librte_compat/rte_compat.h
index d6e79f3fc..2cdc37214 100644
--- a/lib/librte_compat/rte_compat.h
+++ b/lib/librte_compat/rte_compat.h
@@ -1,31 +1,6 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
- *   All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- *     * Redistributions of source code must retain the above copyright
- *       notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above copyright
- *       notice, this list of conditions and the following disclaimer in
- *       the documentation and/or other materials provided with the
- *       distribution.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+/* SPDX-License-Identifier: BSD-3-Clause 
+ * Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
+ * All rights reserved.
  */
 
 #ifndef _RTE_COMPAT_H_
-- 
2.14.3

Re: [dpdk-dev] [PATCH v2] relicense various bits of the dpdk

[Hemant Agrawal]

On 2/1/2018 5:49 PM, Neil Horman wrote:
> Received a note the other day from the Linux Foundation governance board
> for DPDK indicating that several files I have copyright on need to be
> relicensed to be compliant with the DPDK licensing guidelines.  I have
> some concerns with some parts of the request, but am not opposed to
> other parts.  So, for those pieces that we are in consensus on, I'm
> proposing that we change their license from BSD 2 clause to 3 clause.
> I'm also updating the files to use the SPDX licensing scheme
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> 
> ---
> Change notes
> V2) Cleaned up formatting (tmonjalon)
> ---
>   devtools/validate-abi.sh       | 32 ++++----------------------------
>   lib/librte_compat/rte_compat.h | 31 +++----------------------------
>   2 files changed, 7 insertions(+), 56 deletions(-)
> 

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH v2] relicense various bits of the dpdk

[Thomas Monjalon]

01/02/2018 13:49, Hemant Agrawal:
> On 2/1/2018 5:49 PM, Neil Horman wrote:
> > Received a note the other day from the Linux Foundation governance board
> > for DPDK indicating that several files I have copyright on need to be
> > relicensed to be compliant with the DPDK licensing guidelines.  I have
> > some concerns with some parts of the request, but am not opposed to
> > other parts.  So, for those pieces that we are in consensus on, I'm
> > proposing that we change their license from BSD 2 clause to 3 clause.
> > I'm also updating the files to use the SPDX licensing scheme
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> > CC: Thomas Monjalon <thomas@monjalon.net>
> 
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Applied, thanks