From: Ranjit Menon <ranjit.menon@intel.com>
To: Tal Shnaiderman <talshn@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com,
harini.ramakrishnan@microsoft.com
Subject: Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows
Date: Wed, 16 Sep 2020 11:32:10 -0700 [thread overview]
Message-ID: <22b0021f-cf02-1d21-7236-9385e6d5f490@intel.com> (raw)
In-Reply-To: <20200825114316.10712-1-talshn@nvidia.com>
On 8/25/2020 4:43 AM, Tal Shnaiderman wrote:
> Set the domain value for rte_pci_addr probing on Windows
> to the value of the PCI segment returned by SPDRP_BUSNUMBER.
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> drivers/bus/pci/windows/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index 489aa7902a..a40acec609 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -195,8 +195,8 @@ get_device_pci_address(HDEVINFO dev_info,
> return -1;
> }
>
> - addr->domain = 0;
> - addr->bus = bus_num;
> + addr->domain = bus_num >> 8;
> + addr->bus = bus_num & 0xff;
> addr->devid = dev_and_func >> 16;
> addr->function = dev_and_func & 0xffff;
> return 0;
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
next prev parent reply other threads:[~2020-09-16 18:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:43 Tal Shnaiderman
2020-09-09 23:21 ` Narcisa Ana Maria Vasile
2020-09-10 7:30 ` Tal Shnaiderman
2020-09-10 17:21 ` Menon, Ranjit
2020-09-13 14:50 ` Tal Shnaiderman
2020-09-10 17:57 ` Dmitry Kozlyuk
2020-09-13 14:54 ` Tal Shnaiderman
2020-09-16 18:32 ` Ranjit Menon [this message]
2020-10-14 9:01 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b0021f-cf02-1d21-7236-9385e6d5f490@intel.com \
--to=ranjit.menon@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).