From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B059A04B5; Wed, 16 Sep 2020 20:32:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E35521D171; Wed, 16 Sep 2020 20:32:14 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 70ACB1D16D for ; Wed, 16 Sep 2020 20:32:13 +0200 (CEST) IronPort-SDR: rx0kM843ZvUr5j49A9H4U1ztNzGcyCJroFt/vmFdtygyjGZ3Hizp1gcUFVbKCGwp+jHTY1sZau g/hlilASoclw== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="147294492" X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="147294492" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 11:32:12 -0700 IronPort-SDR: cKc+H93ulLLrN0DxSRBuurvrcJ12wIkZYnJpbpjiIb6Zy5BRyyqfN2de3sPoOVKwvTqTUHfCc2 /UTesclZU9sg== X-IronPort-AV: E=Sophos;i="5.76,433,1592895600"; d="scan'208";a="483421623" Received: from rmenon-desk.amr.corp.intel.com (HELO [10.166.30.253]) ([10.166.30.253]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 11:32:11 -0700 To: Tal Shnaiderman , dev@dpdk.org Cc: thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com References: <20200825114316.10712-1-talshn@nvidia.com> From: Ranjit Menon Message-ID: <22b0021f-cf02-1d21-7236-9385e6d5f490@intel.com> Date: Wed, 16 Sep 2020 11:32:10 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200825114316.10712-1-talshn@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH] bus/pci: support segment value as address domain on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/25/2020 4:43 AM, Tal Shnaiderman wrote: > Set the domain value for rte_pci_addr probing on Windows > to the value of the PCI segment returned by SPDRP_BUSNUMBER. > > Signed-off-by: Tal Shnaiderman > --- > drivers/bus/pci/windows/pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c > index 489aa7902a..a40acec609 100644 > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers/bus/pci/windows/pci.c > @@ -195,8 +195,8 @@ get_device_pci_address(HDEVINFO dev_info, > return -1; > } > > - addr->domain = 0; > - addr->bus = bus_num; > + addr->domain = bus_num >> 8; > + addr->bus = bus_num & 0xff; > addr->devid = dev_and_func >> 16; > addr->function = dev_and_func & 0xffff; > return 0; Acked-by: Ranjit Menon