From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id 64F4A1C75F for ; Mon, 14 May 2018 12:46:45 +0200 (CEST) To: "Singh, Jasvinder" , "dev@dpdk.org" References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152627465307.53156.9964743394274041446.stgit@localhost.localdomain> <54CBAA185211B4429112C315DA58FF6D3345CEB2@IRSMSX103.ger.corp.intel.com> From: Andy Green Message-ID: <22b101b3-07cc-94de-c5ee-b367955c388e@warmcat.com> Date: Mon, 14 May 2018 18:46:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <54CBAA185211B4429112C315DA58FF6D3345CEB2@IRSMSX103.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 17/23] test_table_pipeline: repair munged indirection level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 10:46:45 -0000 On 05/14/2018 06:35 PM, Singh, Jasvinder wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green >> Sent: Monday, May 14, 2018 6:11 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v4 17/23] test_table_pipeline: repair munged >> indirection level >> >> Signed-off-by: Andy Green >> --- >> test/test/test_table_pipeline.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/test/test/test_table_pipeline.c b/test/test/test_table_pipeline.c >> index 5ec4c5244..70dbd25f4 100644 >> --- a/test/test/test_table_pipeline.c >> +++ b/test/test/test_table_pipeline.c >> @@ -63,21 +63,21 @@ rte_pipeline_port_out_action_handler >> port_action_stub(struct rte_mbuf **pkts, >> >> rte_pipeline_table_action_handler_hit >> table_action_0x00(struct rte_pipeline *p, struct rte_mbuf **pkts, >> - uint64_t pkts_mask, struct rte_pipeline_table_entry **entry, void >> *arg); >> + uint64_t pkts_mask, struct rte_pipeline_table_entry *entry, void >> +*arg); > > In my opinion , this is wrong fix. Here, table action is meant to be applied on any number of packets (maximum 64), therefore, > entry parameter should be array of up to 64 pointers to rte_pipeline_table_entry structure. BTW, Dave has already sent > fix for gcc 8.1 build error. http://www.dpdk.org/ml/archives/dev/2018-May/101113.html Well, no worries... I saw something was broken (the * vs the **) and simply guessed the resolution. If it's wrong, just drop my patch about this. -Andy