From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 025511BE3D for ; Tue, 3 Jul 2018 12:37:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 03:37:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,303,1526367600"; d="scan'208";a="63750663" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83]) ([10.237.221.83]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2018 03:36:56 -0700 To: "Liu, Yong" , Maxime Coquelin , "Bie, Tiwei" Cc: "Wang, Zhihong" , "dev@dpdk.org" References: <20180702135642.52577-1-yong.liu@intel.com> <20180702135642.52577-8-yong.liu@intel.com> <7ab59556-5719-e05b-ea1f-f94867d90b24@intel.com> <739c4cea-23c8-f1ec-f186-39b74960cb7b@redhat.com> <86228AFD5BCD8E4EBFD2B90117B5E81E630D188A@SHSMSX103.ccr.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <22d95bb6-8d26-a183-d173-eeaa62969e0e@intel.com> Date: Tue, 3 Jul 2018 11:36:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E630D188A@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 10:37:09 -0000 On 7/3/2018 2:36 AM, Liu, Yong wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, July 03, 2018 12:57 AM >> To: Maxime Coquelin ; Liu, Yong >> ; Bie, Tiwei >> Cc: Wang, Zhihong ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and >> Tx >> >> On 7/2/2018 5:53 PM, Maxime Coquelin wrote: >>> >>> >>> On 07/02/2018 06:52 PM, Ferruh Yigit wrote: >>>> On 7/2/2018 5:41 PM, Ferruh Yigit wrote: >>>>> On 7/2/2018 2:56 PM, Marvin Liu wrote: >>>>>> IN_ORDER Rx function depends on merge-able feature. Descriptors >>>>>> allocation and free will be done in bulk. >>>>>> >>>>>> Virtio dequeue logic: >>>>>> dequeue_burst_rx(burst mbufs) >>>>>> for (each mbuf b) { >>>>>> if (b need merge) { >>>>>> merge remained mbufs >>>>>> add merged mbuf to return mbufs list >>>>>> } else { >>>>>> add mbuf to return mbufs list >>>>>> } >>>>>> } >>>>>> if (last mbuf c need merge) { >>>>>> dequeue_burst_rx(required mbufs) >>>>>> merge last mbuf c >>>>>> } >>>>>> refill_avail_ring_bulk() >>>>>> update_avail_ring() >>>>>> return mbufs list >>>>>> >>>>>> IN_ORDER Tx function can support offloading features. Packets which >>>>>> matched "can_push" option will be handled by simple xmit function. >> Those >>>>>> packets can't match "can_push" will be handled by original xmit >> function >>>>>> with in-order flag. >>>>>> >>>>>> Virtio enqueue logic: >>>>>> xmit_cleanup(used descs) >>>>>> for (each xmit mbuf b) { >>>>>> if (b can inorder xmit) { >>>>>> add mbuf b to inorder burst list >>>>>> continue >>>>>> } else { >>>>>> xmit inorder burst list >>>>>> xmit mbuf b by original function >>>>>> } >>>>>> } >>>>>> if (inorder burst list not empty) { >>>>>> xmit inorder burst list >>>>>> } >>>>>> update_avail_ring() >>>>>> >>>>>> Signed-off-by: Marvin Liu >>>>>> Reviewed-by: Maxime Coquelin >>>>> >>>>> <...> >>>>> >>>>>> @@ -150,6 +188,83 @@ virtio_xmit_cleanup(struct virtqueue *vq, >> uint16_t num) >>>>>> } >>>>>> } >>>>>> >>>>>> +/* Cleanup from completed inorder transmits. */ >>>>>> +static void >>>>>> +virtio_xmit_cleanup_inorder(struct virtqueue *vq, uint16_t num) >>>>>> +{ >>>>>> + uint16_t i, used_idx, desc_idx, last_idx; >>>>> >>>>> >>>>> Getting following build error [1], from code it looks like false >> positive, but >>>>> to get rid of the build error would it be OK to set initial value to >> "desc_idx"? >>>> >>>> I applied this while merging, if this is wrong please let me know, we >> can fix in >>>> next-net, Thanks. >>> >>> Looks good to me. I didn't catch it with the GCC version I use. >> >> I didn't dig more but I also didn't get the error with regular build, the >> one >> with all DEBUGs enabled and mach=default combination gave the error, not >> sure why. >> > > Ferruh, > I didn't catch this error either. I tried three gcc versions 7.2.0, 7.3.0 and 4.8.3. > May I know your gcc version? gcc [1] with debug enabled [2], giving error [3]. [1] gcc (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1) make T=x86_64-native-linuxapp-gcc config [2] CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=y CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=y CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=y [3] .../drivers/net/virtio/virtio_rxtx.c: In function ‘virtio_xmit_cleanup_inorder’: .../drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ may be used uninitialized in this function [-Werror=maybe-uninitialized] uint16_t i, used_idx, desc_idx, last_idx; ^~~~~~~~ cc1: all warnings being treated as errors > > Thanks, > Marvin > >>> >>> Thanks, >>> Maxime >>> >>>>> >>>>> >>>>> [1] >>>>> .../dpdk/drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ >> may be used >>>>> uninitialized in this function [-Werror=maybe-uninitialized] >>>>> >>>>> >>>>> uint16_t i, used_idx, desc_idx, last_idx; >>>>> >>>>> >>>>> >>>>> ^~~~~~~~ >>>>> >>>> >