From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f169.google.com (mail-we0-f169.google.com
 [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 8426A9AF6
 for <dev@dpdk.org>; Mon, 23 Feb 2015 18:37:31 +0100 (CET)
Received: by wesq59 with SMTP id q59so20303374wes.1
 for <dev@dpdk.org>; Mon, 23 Feb 2015 09:37:31 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Zi9f4npYN8ydu/Qrk8CfbcTdfYyQTIovE/rxNAxapYU=;
 b=R3nTV2GH8AoLrjuNd/p+1W6PH9ggWChs8jbCqzZnv6T3ujQiKEuA21dY03Zdp9259p
 6mqXiRULcGH9Tzr5QMuCmXxkFeYhJLELgHaW0spwRcNJCpWVT2PqJ0+BYFLutS72ArHd
 IRyjl4oVePNuYdAlBwDTQx3hcQqklaTP+KdVxlUHjFvagoc+O43/UslVVKu412kgVeKc
 hrVR7JRnouyUGv/UxqSHdMNBBUqED9x9NPaldk50Mug5U5G7c6mgFeSRRPtbzpbWQ7ZN
 Bf1mVkSxF1fDDob5OWZ4EfiMB4O9dZ6Wvlrmn4Emv6iBtEL/UEh34aJFxFctsEyUJAO+
 3Vmg==
X-Gm-Message-State: ALoCoQkDi62jWxBMfxOiNeg9x1AW6c1bblv0LbHrqMxQrxl28J4Xt0Bpd91VYD0sER10PIoGkA2b
X-Received: by 10.180.207.6 with SMTP id ls6mr23123766wic.13.1424713049982;
 Mon, 23 Feb 2015 09:37:29 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id m9sm16780591wiz.24.2015.02.23.09.37.27
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 09:37:29 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yerden Zhumabekov <e_zhumabekov@sts.kz>
Date: Mon, 23 Feb 2015 18:36:57 +0100
Message-ID: <2302266.QHkfKt2YM8@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <20150219152129.GA17032@bricha3-MOBL3>
References: <1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz>
 <54CF0D86.3090507@sts.kz> <20150219152129.GA17032@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 0/7] rte_hash_crc reworked to be
	platform-independent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 17:37:31 -0000

2015-02-19 15:21, Bruce Richardson:
> Confirmed, this worked for me too.
> Looking at the patches, they look good. However, one thing I think we are missing
> is a unit test to verify that all our CRC implementations give the same result.
> That would be useful as a sanity check of the software fallback especially. The
> existing hash tests, test the hash table implementation rather than the
> mathematical argorithm used to compute the hash values.
> 
> Overall, though, software fallback for CRC is something well worthwhile having.
> 
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

Note: running doxygen compilation helped me to find and fix a small
mismatch (parameter alg was flag in comment).