From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCDBDA0527; Mon, 9 Nov 2020 14:00:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 87C7E5953; Mon, 9 Nov 2020 14:00:01 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id A63092B9D for ; Mon, 9 Nov 2020 13:59:59 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 9137B5805CF; Mon, 9 Nov 2020 07:59:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 09 Nov 2020 07:59:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= jCRIIqPH0kFgLUPP2rjP+wxiVoAjl71ocd6GFfZtk/k=; b=bS4WRQtYTP8tdCZU nJTNf9RqrhTS63egViO8aC0PkXo2xcszqe7lMm0G+F6Ywljj7/sa78ObpubM2M+0 bqhYyCupsDOfxqk3m5bC+jWFJsY1V3IG90xFBSAGFWUk4zkohEUxcwNBGZDgfsMn GbT97dhBkbdVJbWbZOD76GijyKqZmIzbTUC0YV7xh3GBjuagt14EeIkLpKBq04v/ hK0UtTScGNWP0zQ/943s4Q8Cx732WRRc6Rp6HJRtRBgLP8fY3K2r46ub9JoCVusA jQt+gfDgNRkffbvNp1zdMAu/5PrncB27BFdQAHz+/D6c9YRTB4IKboOFrlGyMpNa U/+25w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jCRIIqPH0kFgLUPP2rjP+wxiVoAjl71ocd6GFfZtk /k=; b=Gajvr1pvzTFvjDFBWnxKvtW28BW9VCeiKWpxI/VsyozvUGnJ0Yu//rV3r t+jsPFT633esoWe/4qHhXLyn61jODG4nnsvV8zVB70x0T/e//Y6uVE8PTFWiWmZe xUcDygFo8VIXhXfYqZ0+Nl/IETtZR6Mj6b5VKvJXzTdOFOLsuUrC7EHm3NFg2mgV u0dwvf8TzaLjuyGGnX7H76zmA1f/SXp/8zQ16neB5OstmtbxtPWA0gC7DECM2my7 8pz+TiG682r63X06YOo+New9RQa+YS1J1De766J40HWqVey+Z45kQMLWlIeC+2wS xi5dVYSYk4fBBaXpb8YdhJ4cDioFg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduhedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 15C00328005A; Mon, 9 Nov 2020 07:59:52 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: Bruce Richardson , dpdk-dev , David Marchand , Ferruh Yigit , Olivier Matz , Morten =?ISO-8859-1?Q?Br=F8rup?= , "Ananyev, Konstantin" , Andrew Rybchenko , Viacheslav Ovsiienko , Ajit Khaparde , Jerin Jacob , Hemant Agrawal , Ray Kinsella , Neil Horman , Nithin Dabilpuram , Kiran Kumar K Date: Mon, 09 Nov 2020 13:59:49 +0100 Message-ID: <2304322.cEvxdTIR8G@thomas> In-Reply-To: References: <20201107155306.463148-1-thomas@monjalon.net> <20201109094732.GA831@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/11/2020 13:01, Jerin Jacob: > Hi @Thomas Monjalon > > Any specific reason why you removed the static assert from octeontx2. I have a build failure when cross-compiling for octeontx2. > I am not able to compilation issue with that static assert. There is no issue when compiling for x86. > The current vector driver assumes pool and tx offload needs to 2 DWORDS apart, > Which is the case before and after your change. You're right, pool and tx_offload are moved together. The only difference is passing the cache line frontier. > Please remove that static assert change, No issue from my side on this patch. I cannot remove it without fixing something else, maybe an issue in cache line alignment? > In general, it is too much effort to re-verify and measure performance > impact with > all the cases after RC2, I hope this will last mbuf change in this release. Yes it is the last change to mbuf layout, sorry for pushing all these changes so late.