[dpdk-dev] [PATCH] net/mlx4: fix missing initializers for old GCCs

[dpdk-dev] [PATCH] net/mlx4: fix missing initializers for old GCCs

[Adrien Mazarguil]

This patch works around compilation issues so far only seen on RHEL 7.2
using GCC 4.8.5:

 [...]/mlx4_rxq.c: In function `mlx4_rx_queue_setup':
 [...]/mlx4_rxq.c:473:3: error: missing initializer for field `ipackets' of
     `struct mlx4_rxq_stats' [-Werror=missing-field-initializers]

 [...]/mlx4_txq.c: In function `mlx4_tx_queue_setup':
 [...]/mlx4_txq.c:265:3: error: missing initializer for field `opackets' of
     `struct mlx4_txq_stats' [-Werror=missing-field-initializers]

Fixes: 79770826499b ("net/mlx4: drop live queue reconfiguration support")

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
 drivers/net/mlx4/mlx4_rxq.c | 4 +++-
 drivers/net/mlx4/mlx4_txq.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c
index 7ce5b26..6fa48bc 100644
--- a/drivers/net/mlx4/mlx4_rxq.c
+++ b/drivers/net/mlx4/mlx4_rxq.c
@@ -469,7 +469,9 @@ mlx4_rx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
 			 dev->data->dev_conf.rxmode.hw_ip_checksum),
 		.csum_l2tun = (priv->hw_csum_l2tun &&
 			       dev->data->dev_conf.rxmode.hw_ip_checksum),
-		.stats.idx = idx,
+		.stats = {
+			.idx = idx,
+		},
 		.socket = socket,
 	};
 	/* Enable scattered packets support for this queue if necessary. */
diff --git a/drivers/net/mlx4/mlx4_txq.c b/drivers/net/mlx4/mlx4_txq.c
index 6d3dd78..a9c5bd2 100644
--- a/drivers/net/mlx4/mlx4_txq.c
+++ b/drivers/net/mlx4/mlx4_txq.c
@@ -261,7 +261,9 @@ mlx4_tx_queue_setup(struct rte_eth_dev *dev, uint16_t idx, uint16_t desc,
 	}
 	*txq = (struct txq){
 		.priv = priv,
-		.stats.idx = idx,
+		.stats = {
+			.idx = idx,
+		},
 		.socket = socket,
 		.elts_n = desc,
 		.elts = elts,
-- 
2.1.4

Re: [dpdk-dev] [PATCH] net/mlx4: fix missing initializers for old GCCs

[Thomas Monjalon]

13/10/2017 11:31, Adrien Mazarguil:
> This patch works around compilation issues so far only seen on RHEL 7.2
> using GCC 4.8.5:
> 
>  [...]/mlx4_rxq.c: In function `mlx4_rx_queue_setup':
>  [...]/mlx4_rxq.c:473:3: error: missing initializer for field `ipackets' of
>      `struct mlx4_rxq_stats' [-Werror=missing-field-initializers]
> 
>  [...]/mlx4_txq.c: In function `mlx4_tx_queue_setup':
>  [...]/mlx4_txq.c:265:3: error: missing initializer for field `opackets' of
>      `struct mlx4_txq_stats' [-Werror=missing-field-initializers]
> 
> Fixes: 79770826499b ("net/mlx4: drop live queue reconfiguration support")
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>

Applied, thanks