From: Thomas Monjalon <thomas@monjalon.net>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO
Date: Fri, 13 Apr 2018 15:08:27 +0200 [thread overview]
Message-ID: <23085973.mySOohilc8@xps> (raw)
In-Reply-To: <dd2307a5-9990-2453-1f5e-71680f472046@intel.com>
13/04/2018 11:11, Burakov, Anatoly:
> On 13-Apr-18 12:39 AM, Thomas Monjalon wrote:
> > 12/04/2018 16:13, Burakov, Anatoly:
> >> On 12-Apr-18 2:34 PM, Shahaf Shuler wrote:
> >>> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n
> >>>
> >>> == Build lib/librte_eal/linuxapp/eal
> >>> CC eal_vfio.o
> >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no
> >>> previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes]
> >>> rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t
> >>> iova,
> >>> ^
> >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no
> >>> previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes]
> >>> rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused
> >>> iova,
> >>> ^
> >>>
> >>> As there is no use for those dummy functions without VFIO removing them
> >>> completely.
> >>
> >> These functions are part of public API, like rest of functions in this
> >> header. They're in the map file. Should we perhaps go the BSD way and
> >> provide EAL with dummy prototypes as well? See bsdapp/eal/eal.c:763 onwards.
> >
> > Why using dummy prototypes?
> > Because the prototypes in rte_vfio.h are under #ifdef VFIO_PRESENT ?
> > Is it possible to always define the prototypes in rte_vfio.h ?
> >
>
> Well, technically, yes, we could. There is one function that uses a
> VFIO-specific struct definition:
>
> int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
> int *vfio_dev_fd, struct vfio_device_info *device_info);
>
> I'm sure we can work around that.
Removing dummy prototypes need, would be a nicer fix.
next prev parent reply other threads:[~2018-04-13 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 13:34 Shahaf Shuler
2018-04-12 14:13 ` Burakov, Anatoly
2018-04-12 23:39 ` Thomas Monjalon
2018-04-13 9:11 ` Burakov, Anatoly
2018-04-13 13:08 ` Thomas Monjalon [this message]
2018-04-13 13:37 ` Burakov, Anatoly
2018-04-13 13:58 ` Thomas Monjalon
2018-04-16 5:50 ` Shahaf Shuler
2018-04-16 10:09 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23085973.mySOohilc8@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).