From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9F6E01BB67 for ; Fri, 13 Apr 2018 15:08:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0EEC1212A5; Fri, 13 Apr 2018 09:08:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 13 Apr 2018 09:08:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=OVVwr2q4cMKRYnK0TiXfPZ5RJS 4mrYHUH9ZTvwzNSkE=; b=fYtuB5niZOmCEOfQ3kD+SYTKLsEUyGotnwv/skzo85 WQYGLkH/tuQssA7opWyQlK31evZK5R4mDhcSJtDLInTtiHo3s6bdygUXsncs8TFl c9/MALwTnb+PvfggUo7T25XLE4Zy8XfqQpBMj146YSfUS8uoFbwfi99+tPWkS5H2 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=OVVwr2 q4cMKRYnK0TiXfPZ5RJS4mrYHUH9ZTvwzNSkE=; b=T2xWZdQZmhEEynIiF0IiTU jccaOdhqIKMkn5JcKwz/XVcGEd8K/yuArXOGybVwZhi4IX81KGz51CB3IApbBfvW 6H64PTKo9MEoH2aM4THrVda0xnK+LiR/siRVob3x0ScAEpvfwAzZuCPyfxY4e3kl 1duxSn5EmLrfDkzRdRnBpo5npmfoFr4/MZsklAh6PMkHKE/Sz4BLyA6S3vWZnRDL U2SXxpSkQcYFHQ2nBgLzvYgXltACWt+6JwCqdG8sW7mMg8TkWlE0ws6ml7TslR1v KiWZZxvXVijyRZYv7JVjeApJ5KcZIr4zZEEHpTWp8kyS86OODMMfpLZY/K28wvRQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4EE1FE442C; Fri, 13 Apr 2018 09:08:28 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Shahaf Shuler Date: Fri, 13 Apr 2018 15:08:27 +0200 Message-ID: <23085973.mySOohilc8@xps> In-Reply-To: References: <20180412133422.104155-1-shahafs@mellanox.com> <7325634.395TUUszRC@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix compilation without VFIO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 13:08:29 -0000 13/04/2018 11:11, Burakov, Anatoly: > On 13-Apr-18 12:39 AM, Thomas Monjalon wrote: > > 12/04/2018 16:13, Burakov, Anatoly: > >> On 12-Apr-18 2:34 PM, Shahaf Shuler wrote: > >>> a compilation error occurred when compiling with CONFIG_RTE_EAL_VFIO=n > >>> > >>> == Build lib/librte_eal/linuxapp/eal > >>> CC eal_vfio.o > >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1535:1: error: no > >>> previous prototype for 'rte_vfio_dma_map' [-Werror=missing-prototypes] > >>> rte_vfio_dma_map(uint64_t __rte_unused vaddr, __rte_unused uint64_t > >>> iova, > >>> ^ > >>> /download/dpdk/lib/librte_eal/linuxapp/eal/eal_vfio.c:1542:1: error: no > >>> previous prototype for 'rte_vfio_dma_unmap' [-Werror=missing-prototypes] > >>> rte_vfio_dma_unmap(uint64_t __rte_unused vaddr, uint64_t __rte_unused > >>> iova, > >>> ^ > >>> > >>> As there is no use for those dummy functions without VFIO removing them > >>> completely. > >> > >> These functions are part of public API, like rest of functions in this > >> header. They're in the map file. Should we perhaps go the BSD way and > >> provide EAL with dummy prototypes as well? See bsdapp/eal/eal.c:763 onwards. > > > > Why using dummy prototypes? > > Because the prototypes in rte_vfio.h are under #ifdef VFIO_PRESENT ? > > Is it possible to always define the prototypes in rte_vfio.h ? > > > > Well, technically, yes, we could. There is one function that uses a > VFIO-specific struct definition: > > int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, > int *vfio_dev_fd, struct vfio_device_info *device_info); > > I'm sure we can work around that. Removing dummy prototypes need, would be a nicer fix.