From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E67391B5B5 for <dev@dpdk.org>; Thu, 10 Jan 2019 10:09:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F372F23218; Thu, 10 Jan 2019 04:09:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 10 Jan 2019 04:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=stRrPRzO+lPA5vmyCXFhgetNnvnsaxgpHW2JS8sO9lM=; b=lvUaDCv6s8P2 ZSIzZtBBbdzAQ6JOIrd0LO516AHZwawEOGLBuFV0xJAGItIV+uLGUqrQC0C5fseL oQxWQap4t9xtSvA/NYcs74pMJWkTV5nrigganzjff/o89/+rMPxtdGu1bPwk0t46 JYgfrnw5c6oO1EvGkQTjI25MfsfTODg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=stRrPRzO+lPA5vmyCXFhgetNnvnsaxgpHW2JS8sO9 lM=; b=UMnZe0LAMRVDTF+ZSOICNYADiForZu8EvH0/FrWeKj9ho9bi3M/ywlm5F AfhPVgqzcTqIeU3LGprnguJ+jqGYEktcpQmxMni97yIFugudHW4KLWfQc/A+5NjO Q6xEeEbC9+lD+d96xCP3YCkWCKHUjouqk4GpOtG2OGRnp27ejD2CScq+Bnz3sWY2 yYc/Kzavb8YVA0qowiz76XLM9LsWkSsdx78Lqau0ljqAM97I6O2JpgutZ+G7qphf U/srvvRKmwaxJ4IlLsZxgZ6y7G2bVYn7cq9Z2X/HvnMyGV5HzwX6dhIBGZj3v5/a l/cZ5rZl1mklL9uZrt0L3T3WKykcw== X-ME-Sender: <xms:rgs3XLEvg6W8MH91JWfmpBnUNKRXAy2jy_1DbEmNTuLbGY5k-70agg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeefucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemuceftddtnecu secvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtg esthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrghinhepvhejrdhsohenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:rgs3XMlJBWwNS8R9Wlf7Pt0r8Zr-UYcvOSB9NCZaPI2K08D5Qwl59Q> <xmx:rgs3XILtgdN3E9PEyX78I-gVlIdW3rq0tyvbrSVtfgKT15KIdwQoVQ> <xmx:rgs3XNb1i4iTCkWZ1lKiMLAcRyQNkDXHvDELhU4KdDEL3p3xsUGfTQ> <xmx:rgs3XKVrPjGubxhbrpt5urLJXYOig_J06KABIwA9UW-z-FQc1iya0Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5A10410106; Thu, 10 Jan 2019 04:09:01 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Varghese, Vipin" <vipin.varghese@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Patel, Amol" <amol.patel@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Singh, Jasvinder" <jasvinder.singh@intel.com> Date: Thu, 10 Jan 2019 10:09:00 +0100 Message-ID: <23092145.fqvuDreClZ@xps> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com> References: <20181213050842.64587-1-vipin.varghese@intel.com> <4383677.neL5jlz7Vu@xps> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/7] app/procinfo: prepare for new debug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 10 Jan 2019 09:09:04 -0000 10/01/2019 09:53, Varghese, Vipin: > Hi Thomas, > > snipped > > > > 10/01/2019 04:08, Varghese, Vipin: > > > snipped > > > > > > > > Hi Vipin, > > > > > > > > The code split in this v8 looks really better, except this patch > > > > which makes no sense alone. > > > Hi Thomas, I need this base patch as first one. These include the helper > > MACRO and include which pans out for next 7 patches. > > > > > > > I feel you can move these changes in next patches, where appropriate, isn't > > it? > > > Patches v2 to v7 uses common features from v1. > > > > At least, you should introduce the includes when needed. > As mentioned earlier these are used in v2 to v7. So? They must be introduced first time they are used. Vipin, please be cooperative. > > If you need this patch for introducing some macros, then rename it and > > explain the macros in the message. > The MACRO introduced in this patch are 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR'. As per code contribution guideline I may have missed out the stipulation requesting for explaining the same. > > > > > > > > > 07/01/2019 16:38, Vipin Varghese: > > > > > Update code base and meson build file to accommodate changes for > > > > > the new functionality. > > > > > > > > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > > > > > Acked-by: Reshma Pattan <reshma.pattan@intel.com> > > > > > --- > snipped >