From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34D97A04FD; Wed, 22 Jun 2022 10:46:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E20354069C; Wed, 22 Jun 2022 10:46:06 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 2BFFB40689 for ; Wed, 22 Jun 2022 10:46:05 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D51835C00A5; Wed, 22 Jun 2022 04:46:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 22 Jun 2022 04:46:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1655887562; x= 1655973962; bh=51oAVHqxZ2VriAi4sY+Vvb8Ogmb6EACPhhu8AyMK788=; b=H l98xtagi15Hqo+/uhrPkEe7qUdpZpLhybicXHbRE+y0iNzRaa4WqjGXplAbzgAD0 P5ZuSI6PDlV4tQbZlEm/qNB9TQI9l46wa4RXqGDnIdOMWVsVBQ6WMhHO0jZ8NDGT wWP0wYt3z9g17TJLK7JlBg3bnxYUxx0vJbaEHpIxM5zfyobDX+EKpPhZMEGxEg3O 3y9xyoDKuC3Kgvt0XmOR5MnGNhRhrFx9fGuN8Wk7mPQ6Tv88KiZi6rHroR8WM94A LxTZRYyVxmOsFu2MNNlM9fYfMZW+our2sRC9xQlQaTW9odiy5MCEX0AVIqJmbK8D 7HSct1vGimq/0qwuUqO7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655887562; x= 1655973962; bh=51oAVHqxZ2VriAi4sY+Vvb8Ogmb6EACPhhu8AyMK788=; b=n M3H3aqwxHPKNbu+wh1XNRQvZ5CY35qBaYSR6VpNvD9m6JTGcKS3fPWK3F4j2ZpL1 9A+fHb1LF23RC34/kePdqD4YYHefeo/U7X/D9s6rur76MNA8Lx0/grUT3C2UA34K OZLb+MoFY+261cd1Ik0iEus3OwMaDH7qsI9/QT+oxeyXyybljjRUTy6PGh/mOprj HlGsNO5pIZaKIjXWnDsuLGK504qfnyuwSnvs+d5lZQRQbHIBMbLcSW6IrhQAyKQe /+FPzBre0ZDK4cXTku4b0K7ERZ194vsZfv60dQRZjZ51mMmHGu4HdCsWNj3Wcz9H 4nb3vZz5OsiMzXrcyLsug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefhedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Jun 2022 04:46:02 -0400 (EDT) From: Thomas Monjalon To: Matan Azrad , Maxime Coquelin Cc: "dev@dpdk.org" , "835703180@qq.com" <835703180@qq.com> Subject: Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed Date: Wed, 22 Jun 2022 10:46:01 +0200 Message-ID: <23095133.hxa6pUQ8Du@thomas> In-Reply-To: <0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com> References: <0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 22/06/2022 10:11, Maxime Coquelin: > >>> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c > >>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c > >>> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv > >> *priv) > >>> rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED); > >>> if (priv->err_intr_handle == NULL) { > >>> DRV_LOG(ERR, "Fail to allocate intr_handle"); > >>> + rte_errno = ENOMEM; > > > > Shouldn't rte_intr_instance_alloc set it? > > I think it makes sense, Thomas could you drop the patch while pulling my > branch? Or do you prefer I remove it directly from my tree? I'll drop it, no problem.