From: Thomas Monjalon <thomas@monjalon.net>
To: "Yu, DapengX" <dapengx.yu@intel.com>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
dev@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix null pointer dereference
Date: Fri, 30 Jul 2021 13:33:08 +0200 [thread overview]
Message-ID: <2310711.Hr5GLslOta@thomas> (raw)
In-Reply-To: <BN9PR11MB525890A92EF387DE915365DDE0E99@BN9PR11MB5258.namprd11.prod.outlook.com>
> > From: Dapeng Yu <dapengx.yu@intel.com>
> >
> > When there is no "firmware" in arguments, the "firmware" pointer is null,
> > and will be dereferenced by rte_strscpy().
> >
> > This patch moves the code block which copies character string from
> > "firmware" to "p->firmware" into the "if" statements where "firmware"
> > argument exists and it is duplicated successfully.
> >
> > Coverity issue: 372136
> > Fixes: d8f852f5f369 ("net/softnic: fix memory leak in arguments parsing")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Applied, thanks.
prev parent reply other threads:[~2021-07-30 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 8:14 dapengx.yu
2021-07-27 9:16 ` Singh, Jasvinder
2021-07-30 11:33 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2310711.Hr5GLslOta@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dapengx.yu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).