From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 408C2A00BE; Fri, 12 Jun 2020 23:55:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A71ED1C10B; Fri, 12 Jun 2020 23:55:24 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 66BF91C0D9 for ; Fri, 12 Jun 2020 23:55:22 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id D1B345801B3; Fri, 12 Jun 2020 17:55:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 12 Jun 2020 17:55:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 7mX73pl660+QH9MoWPbmnSgy7lM0dUVijuqZWzuoZzA=; b=BKgFsD+4ZzP0vA3N arKFusFLXvFh+sm3CwwJbDUsBwR6z2Sjg+IMiX2OKmNTsfBugiqR9VRSY0HGRDhL tojzM+Ti4TRVDPIdKgJoKwF4mARgLIY2wD/WjuuqNT+Okf+Z0XaPSJDHUB7do1+l FdISMK8jNxdOIeEfX2xllCWEcRdwmNXf9YTDwRE4Oo8ODug0KafayK4zqmBT6Wtr ZTRCo8LTwsrGNAVMUAXOH3u7fZUjSD2H5dSq67BiHojC0mefR1QgWVEPSG/RXXUg Q52CmVdEX371X2M72T+sYmdLAYSBnxqCcI4mdnEedf6DcGRGrwkHiQonyPmm5NHo VOLBig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=7mX73pl660+QH9MoWPbmnSgy7lM0dUVijuqZWzuoZ zA=; b=qZr6smIPghLP0EqxNr+ZxSrnctsmjyw9kOCshmFYwLm2XnGJfaUjNnzUT Ut1oVIf5triqqK+p5RLhmLvQMFUxah3kF1CPg5b/5TM3rsyTbh+TkHuzVJ6IM3zK Jjt43IFJaOeCv+eIeeVnwA1HIyupyt/JyH/YGgzACwwgMcVu3YtoMWphQc9l4w+O +VsD5YLKJ/2Bq0caqJrAPilCc79JkO55mUvJMSzLbf/lCKHCSXeEv5waSDQpxRoV cvl+FF02P0U74vd219jAKRxmLQE6Xoq5WY2sIIsVLcNe0iw2nuOjazLUmToZRNvs EarHYMiqFRXQzfByy3MQct/YWykpw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeivddgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 26F783280064; Fri, 12 Jun 2020 17:55:20 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon , John McNamara , Marko Kovacevic Date: Fri, 12 Jun 2020 23:55:19 +0200 Message-ID: <2311794.l2u2mAKTbH@thomas> In-Reply-To: <20200610142730.31376-11-dmitry.kozliuk@gmail.com> References: <20200608074153.29611-1-dmitry.kozliuk@gmail.com> <20200610142730.31376-1-dmitry.kozliuk@gmail.com> <20200610142730.31376-11-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 10/11] eal/windows: initialize hugepage info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/06/2020 16:27, Dmitry Kozlyuk: > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Windows memory allocation > +M: Dmitry Kozlyuk > +F: lib/librte_eal/eal_hugepages.c Is it a typo? You mean lib/librte_eal/windows/eal_hugepages.c ? [...] > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/windows_gsg/build_dpdk.rst > -Run the helloworld example > -========================== > - > -Navigate to the examples in the build directory and run `dpdk-helloworld.exe`. > - > -.. code-block:: console > - > - cd C:\Users\me\dpdk\build\examples > - dpdk-helloworld.exe > - hello from core 1 > - hello from core 3 > - hello from core 0 > - hello from core 2 > - > -Note for MinGW-w64: applications are linked to ``libwinpthread-1.dll`` > -by default. To run the example, either add toolchain executables directory > -to the PATH or copy the library to the working directory. > -Alternatively, static linking may be used (mind the LGPLv2.1 license). [...] > --- /dev/null > +++ b/doc/guides/windows_gsg/run_apps.rst > +Run the ``helloworld`` Example > +------------------------------ > + > +Navigate to the examples in the build directory and run `dpdk-helloworld.exe`. > + > +.. code-block:: console > + > + cd C:\Users\me\dpdk\build\examples > + dpdk-helloworld.exe > + hello from core 1 > + hello from core 3 > + hello from core 0 > + hello from core 2 > + > +Note for MinGW-w64: applications are linked to ``libwinpthread-1.dll`` > +by default. To run the example, either add toolchain executables directory > +to the PATH or copy the library to the working directory. > +Alternatively, static linking may be used (mind the LGPLv2.1 license). I tend thinking that such move is better understood in a separate prior patch.