From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id BE3CD214A for ; Fri, 1 Jul 2016 12:05:21 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id v199so19987457wmv.0 for ; Fri, 01 Jul 2016 03:05:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=QhoZQe3uxO07CGDxyk4VY/zwJKrPIm1cRvGG9ZbtRnI=; b=GThVrac1iwVY8rBUbVls2x8rdnetWRfvK/9/bAVT0Cl/mWsNGITfQqqhBJ4T9bw5kr pvK6cGqle2u5N7Up3tMcXHhh8d7F15HZsogG0KA6JcaWLDenHV6cFBsbV8Ed3IBr+WfG WNXK5tOpIyPxuTEqUL4BugeHSBEGIcibFpzlM6ONiaUAzHmnrqnhTArQws/uc0kcm9WX i4d+hHMpMSwkhhLuiPNTDUKR30SJtrd3FugA3EZhWGAKZuVTNdIK3nAWmnzQUCDidRJI XEM+Yo/P8J+eyN0wfpNYU6m6ACxrxREUg8UWLkBbN1uarVt25zfBkP6aOweIs4HH7eNn MB2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=QhoZQe3uxO07CGDxyk4VY/zwJKrPIm1cRvGG9ZbtRnI=; b=NifOeHb1C6Ykes0ccFqLUPRZqjFF2u8D96ApbPkiW8tOYKbkezB6RsSq2+uXxq6FxI C5GOD8miQFHF+Oje8M9iMJGgW0BvLXFKf5aLS83L509qE+JXtLaprNZZ5E6OoEbmg9u1 N1e8TIecIzA+1KnSBUJrDHBk001m1kXxZF0vYbYIMg1gopHsFYnB+/mSqjIdwUPo8a2C bIYCpLnEASRhRUwm5ja2vU3QigP51iD+pHzuL12UXUfQgkN6U3DkiRmBo8meIdhHC6gk agxAK96Nb3LLV7OpwtENaBXR1GpKaXBXFiCJFw2iFNBrbw7Eu2unk8djIgQxQgqjZS6Y FgxA== X-Gm-Message-State: ALyK8tJZy8myVyhw9K4i9mruxUb/mrMu5qvffwULGiQ2UfeM9DYLo3i0+mSt9l1YWeqaGYBv X-Received: by 10.28.157.199 with SMTP id g190mr20050163wme.2.1467367521561; Fri, 01 Jul 2016 03:05:21 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r6sm3040288wme.14.2016.07.01.03.05.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 03:05:20 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: dev@dpdk.org, konstantin.ananyev@intel.com Date: Fri, 01 Jul 2016 12:05:20 +0200 Message-ID: <2311852.Z0M9311phZ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <71ededc3-4724-5f16-67a3-c9554543f256@intel.com> References: <1467285021-103920-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1872534.DI0OsGElcv@xps13> <71ededc3-4724-5f16-67a3-c9554543f256@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mk: fix acl library static linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2016 10:05:21 -0000 2016-07-01 09:05, Sergio Gonzalez Monroy: > On 30/06/2016 17:22, Thomas Monjalon wrote: > > 2016-06-30 17:14, Sergio Gonzalez Monroy: > >> On 30/06/2016 17:10, Thomas Monjalon wrote: > >>> 2016-06-30 17:01, Sergio Gonzalez Monroy: > >>>> --- a/mk/rte.app.mk > >>>> +++ b/mk/rte.app.mk > >>>> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm > >>>> -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power > >>>> > >>>> _LDLIBS-y += --whole-archive > >>>> > >>>> +# librte_acl needs --whole-archive because of weak functions > >>>> +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH) += -lrte_hash > >>>> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost > >>> I was suggesting to keep -lrte_acl at the same place in the group of > >>> algorithms libraries, in order to keep an order satisfying this comment: > >>> # Order is important: from higher level to lower level > >>> > >>> But I have not tested if --whole-archive -lrte_acl --no-whole-archive works. > >>> > >> Sorry, I missed that. > >> > >> Why is important being before jobstats and power? > > It is not. > > But I think we need to have some groups. > > And ACL is probably at the same layer level as lpm, sched, etc. > > I guess I just don't see the groups you are mentioning :) I define groups as separated by blank line :) > How are timer, hash and vhost in the same group? It is far from perfect and subject to improvements :) > Wouldn't hash be in the same group as acl and lpm? It makes sense to use hash in drivers (example: enic).