From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
Date: Tue, 25 Aug 2015 15:42:55 +0200 [thread overview]
Message-ID: <2313107.TsUIiMEBE8@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2022FB583@IRSMSX103.ger.corp.intel.com>
2015-08-25 13:34, Mcnamara, John:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > This patch should not be accepted to discourage build-time options.
> > Patch for run-time option is welcome.
>
> The patch is fixing a compilation issue, which seems reasonable. It isn't
> introducing a build time option, it is merely fixing an typo in an
> existing one.
Yes
> Yes, it would be better not to have this build time option (in which case
> the issue would have been found sooner) but that isn't the responsibility
> of the person submitting this patch.
Yes
> That is something that should be pushed back to the author/maintainer.
Yes
> In the meantime this patch is still valid and should be applied.
No
After trying to request this kind of cleanup for several months, nothing
happens. Maybe it will be more efficient to leave bugs until someone
submit a real cleanup.
prev parent reply other threads:[~2015-08-25 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 15:55 Ian Stokes
2015-08-18 22:36 ` Mcnamara, John
2015-08-25 12:36 ` Thomas Monjalon
2015-08-25 13:34 ` Mcnamara, John
2015-08-25 13:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2313107.TsUIiMEBE8@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).