From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id DB0E45A33 for ; Tue, 25 Aug 2015 15:44:07 +0200 (CEST) Received: by wicne3 with SMTP id ne3so15769281wic.0 for ; Tue, 25 Aug 2015 06:44:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=TuYq6vTAXs+Ecm/UonwSrtoSEfA9xjJNWQ1W98fVNiU=; b=B55nLavbxQji5csqOE5At0W/HbUQMSNU4dgMmxu9oSYvUpb+Q7PNYS6q2YRkHIWoFy Y7y1IgPjzKd/UxTNLSZhtLhlDdVjlXX+Q1/BMd8jMOIYkJpJ/H09dSrJ+qI8Bk3twuO2 RSr8LxHIrADq3hs9g+YMgcbeKv6+IlXt+vPo9+EsMfDA5lTSy1TnqmvotIg7Z3WvXmOn xkRRa8fbMgE0hu0rxF9XMtKtq9QRQs2NTssmLpQkvzKFZB/VzYsUN7svqVTOew1k349q YE5wLbte4Xq/F46OIa0m2uFkYFZRZFMb7EDpXXqTmvz/4Mw0rOrAUy5WRK59r5fEbnAz DIwQ== X-Gm-Message-State: ALoCoQkzCA6yX3Jc8VerA2+zNwPabBPmcz3yJJORyiB+SD/c+hkK1/wUo4a7RDVMN//1vs0CqBIZ X-Received: by 10.180.198.132 with SMTP id jc4mr5127255wic.82.1440510247693; Tue, 25 Aug 2015 06:44:07 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ne7sm2754532wic.12.2015.08.25.06.44.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Aug 2015 06:44:06 -0700 (PDT) From: Thomas Monjalon To: "Mcnamara, John" Date: Tue, 25 Aug 2015 15:42:55 +0200 Message-ID: <2313107.TsUIiMEBE8@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1439913312-14761-1-git-send-email-ian.stokes@intel.com> <1677849.ZVAMZEjUYk@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2015 13:44:08 -0000 2015-08-25 13:34, Mcnamara, John: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > This patch should not be accepted to discourage build-time options. > > Patch for run-time option is welcome. > > The patch is fixing a compilation issue, which seems reasonable. It isn't > introducing a build time option, it is merely fixing an typo in an > existing one. Yes > Yes, it would be better not to have this build time option (in which case > the issue would have been found sooner) but that isn't the responsibility > of the person submitting this patch. Yes > That is something that should be pushed back to the author/maintainer. Yes > In the meantime this patch is still valid and should be applied. No After trying to request this kind of cleanup for several months, nothing happens. Maybe it will be more efficient to leave bugs until someone submit a real cleanup.