From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B134A0C50; Fri, 23 Jul 2021 16:14:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB97F4014D; Fri, 23 Jul 2021 16:14:35 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9748C40040 for ; Fri, 23 Jul 2021 16:14:34 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 338945C00DE; Fri, 23 Jul 2021 10:14:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 23 Jul 2021 10:14:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 5XSZZ00lABpbWgTMJ9mdyj1HPTIpJZQDGA7Afcoea4g=; b=TtJ7ly56J4XOchkW Hk9dA0dmo8sl11MCCNZCZtdURbfb0VBsc7Ba5dUInkhoFLMU+wNNJX2zZIPS2ryM TbMr/VFBlHrCefehMXdLuFAvrdvfh34GgLYn0fchbpQv1aCfk8u5a1iJ1dsKos6n EPLe1gKRYPjESTXq5UEJ3KDiiAhseI9sb6n7prb+6jZtcwqN3wI2NUAhZ6P1F2uU 0FfKg0fzPJeMXHAE4fIzi41cmtUcs2KFrCoDdUGs0QOTNYGFC4GCtr7YogyrsBEL or9Tczf5rPwCpd8jqnEigP6V3G6+59WHfuhjxs4LId72NAr05ELKCHpoNDC9GMud D3PXRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=5XSZZ00lABpbWgTMJ9mdyj1HPTIpJZQDGA7Afcoea 4g=; b=mSptY4PF0x/xBSjmrpEoiYRbRQp3UU59zQpx3yjxxmJ+buFYRIN4vlsJL vKl+NQXytRQYVqivH3AYbd6+rLEi7V9TbdzPJTLEx3ZBu2W9qNjG/9woOX8A9hvt J8KD3Ohw9oJkIAkdLD+4EriJS7VC2W2sBtQgnELi59mtSmqtpYZ3CKubLCytQoP1 xsGT2dRUN/YGP07GM1DqgCkoMxNM46mToL6JBxbR2NOZI72rzZ9wzQjM8ZJevEfL a6B8ZLggFIZoc5ZpLONQuGB4TUvalaFBXebMErtZOwpA3ZT0gEmcTnWQ3314leZj EA0rL81osR9atfE2V3X3LkUlTVxFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 10:14:32 -0400 (EDT) From: Thomas Monjalon To: Heinrich Kuhn Cc: dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko Date: Fri, 23 Jul 2021 16:14:54 +0200 Message-ID: <2313145.lpj6sdKJKW@thomas> In-Reply-To: <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru> References: <20210518104115.1427712-1-ferruh.yigit@intel.com> <691e140d-ecd2-c963-0dc6-709b40be7f2b@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/nfp: remove compile time log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Please review. 28/06/2021 13:13, Andrew Rybchenko: > Hi Heinrich, > > could you take a look at the patch? > > Thanks, > Andrew. > > On 5/18/21 1:41 PM, Ferruh Yigit wrote: > > Logging should be converted to dynamic log. > > > > Signed-off-by: Ferruh Yigit > > --- > > drivers/net/nfp/nfp_net_logs.h | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_net_logs.h > > index 27dd87611b94..76cc94cb6565 100644 > > --- a/drivers/net/nfp/nfp_net_logs.h > > +++ b/drivers/net/nfp/nfp_net_logs.h > > @@ -30,14 +30,7 @@ extern int nfp_logtype_init; > > #define ASSERT(x) do { } while (0) > > #endif > > > > -#define RTE_LIBRTE_NFP_NET_DEBUG_CPP > > - > > -#ifdef RTE_LIBRTE_NFP_NET_DEBUG_CPP > > -#define PMD_CPP_LOG(level, fmt, args...) \ > > - RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ## args) > > -#else > > #define PMD_CPP_LOG(level, fmt, args...) do { } while (0) > > -#endif > > > > extern int nfp_logtype_driver; > > #define PMD_DRV_LOG(level, fmt, args...) \