From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: don't parse build configs of explicitly disabled drivers
Date: Tue, 19 May 2020 16:50:56 +0200 [thread overview]
Message-ID: <2315401.7eYt6pKtYU@thomas> (raw)
In-Reply-To: <20200507101350.123873-1-dariusz.stojaczyk@intel.com>
07/05/2020 12:13, Darek Stojaczyk:
> Even when a PMD was disabled with meson's disable_drivers option
> its config file was still being parsed. Some of the PMD configs
> attempt to find a library they depend on and parse its header files
> with certain assumptions. If the library is found, but it's simply
> too old to contain the necessary header files, the meson build
> fails and it can only be fixed by either updating that library, or
> expanding the meson script for the faulty PMD.
>
> While the latter should be still done for the sake of DPDK quality,
> an intermediate solution would be to skip building the faulty PMD
> - there's a chance we don't need it. That's what this patch allows.
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2:
> - simplified the code with if X.contains(), as Bruce suggested
> - removed the related comment from the code - it should be
> self-documented now
Applied, thanks
prev parent reply other threads:[~2020-05-19 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 9:22 [dpdk-dev] [PATCH] " Darek Stojaczyk
2020-03-26 11:03 ` Bruce Richardson
2020-03-30 13:52 ` Bruce Richardson
2020-05-07 10:16 ` Stojaczyk, Dariusz
2020-05-07 10:13 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2020-05-19 14:50 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2315401.7eYt6pKtYU@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).